Godot: 3.2 beta - shadows from DirectionalLight broken on android gles2

[avril-gh]

Godot version:
Godot Engine v3.2.beta.custom_build.953f37f49

OS/device including version:

Android GLES: ARM, Mali-450 MP, OpenGL ES 2.0
GL_EXT_debug_marker GL_OES_texture_npot GL_OES_compressed_ETC1_RGB8_texture GL_OES_standard_derivatives GL_OES_EGL_image GL_OES_depth24 GL_ARM_rgba8 GL_ARM_mali_shader_binary GL_OES_depth_texture GL_OES_packed_depth_stencil GL_EXT_texture_format_BGRA8888 GL_OES_vertex_half_float GL_EXT_blend_minmax GL_OES_EGL_image_external GL_OES_EGL_sync GL_OES_rgb8_rgba8 GL_EXT_multisampled_render_to_texture GL_EXT_discard_framebuffer GL_OES_get_program_binary GL_ARM_mali_program_binary GL_EXT_shader_texture_lod GL_EXT_robustness GL_OES_depth_texture_cube_map GL_KHR_debug
EGL:
EGL_KHR_image EGL_KHR_image_base EGL_KHR_image_pixmap EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_fence_sync EGL_ANDROID_image_native_buffer EGL_ANDROID_recordable EGL_ANDROID_native_fence_sync EGL_ANDROID_framebuffer_target EGL_EXT_create_context_robustness EGL_ANDROID_blob_cache

Issue description:
DirectionalLight shadows are broken on android gles2 device.
SpotLight shadows seems to work as intended on android gles2 device.
OmniLight shadows seems to work as intended on android gles2 device.
All three light types seems to work ok on desktop PC.
There are no error's in log.

(there are grid because image is taken from editor)

but on android it looks like whole scene is covered with one huge shadow

(whole scene is more dark and there are no shadow shape)

Steps to reproduce:
try example project on android gles2 device

Minimal reproduction project:
DirectionalLight_shadow.zip

[clayjohn]

Are you getting any errors?

I can't reproduce on my Google Pixel (but it also supports GLES3)

[avril-gh]

Are you getting any errors?

dont know, will see when i'll be back home.
are that google pixel real gles2 ?

[avril-gh]

Godot Engine v3.2.beta.custom_build.953f37f49

tested it more and thats what i got

DirectionalLight shadows are broken on android gles2 device.
SpotLight shadows seems to work as intended on android gles2 device.
OmniLight shadows seems to work as intended on android gles2 device.
All three light types seems to work ok on desktop PC.
There are no error's in log.

i have updated issue title and first post to better describe issue as it seems it only affect DirectionalLight

[avril-gh]

this is OmniLight shadow on android (seems ok)

this is DirectionalLight shadow on android (seems broken)

There are additional properties on DirectionalLight - DirectionalShadow, when you change it you can see different outcomes (like on picture above)
This might be source where problem occurs since the other light's does not have it and they work ok.

[Calinou]

@avril-gh Does the DirectionalLight shadow look correct on Android in 3.1.1?

[avril-gh]

@Calinou

it appears that on 3.1.1 and 3.1.2 directional light looks ok and on 3.2 its broken.
omni light on all three seems to work,
spot light seems to glitch on all tested versions.

3.1.1-stable
directional on android gles2 mali400

omni on android gles2 mali400

spot on android gles2 mali400

v3.1.2.rc.custom_build.261b9d1
directional on android gles2 mali400

omni on android gles2 mali400

spot on android gles2 mali400

v3.2.beta.custom_build.953f37f49
directional on android gles2 mali400

omni on android gles2 mali400

spot on android gles2 mali400

test project used
DirectionalLight_shadow.zip

device caps

GLES: ARM, Mali-400 MP, OpenGL ES 2.0
GL_EXT_debug_marker GL_OES_texture_npot GL_OES_compressed_ETC1_RGB8_texture GL_OES_standard_derivatives GL_OES_EGL_image GL_OES_depth24 GL_ARM_rgba8 GL_ARM_mali_shader_binary GL_OES_depth_texture GL_OES_packed_depth_stencil GL_EXT_texture_format_BGRA8888 GL_OES_vertex_half_float GL_EXT_blend_minmax GL_OES_EGL_image_external GL_OES_EGL_sync GL_OES_rgb8_rgba8 GL_EXT_multisampled_render_to_texture GL_EXT_discard_framebuffer GL_OES_get_program_binary GL_ARM_mali_program_binary GL_EXT_shader_texture_lod GL_EXT_robustness GL_OES_depth_texture_cube_map GL_KHR_debug
EGL:
EGL_KHR_image EGL_KHR_image_base EGL_KHR_image_pixmap EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_fence_sync EGL_ANDROID_image_native_buffer EGL_ANDROID_recordable EGL_ANDROID_framebuffer_target EGL_EXT_create_context_robustness EGL_ANDROID_blob_cache

GLES: ARM, Mali-450 MP, OpenGL ES 2.0
GL_EXT_debug_marker GL_OES_texture_npot GL_OES_compressed_ETC1_RGB8_texture GL_OES_standard_derivatives GL_OES_EGL_image GL_OES_depth24 GL_ARM_rgba8 GL_ARM_mali_shader_binary GL_OES_depth_texture GL_OES_packed_depth_stencil GL_EXT_texture_format_BGRA8888 GL_OES_vertex_half_float GL_EXT_blend_minmax GL_OES_EGL_image_external GL_OES_EGL_sync GL_OES_rgb8_rgba8 GL_EXT_multisampled_render_to_texture GL_EXT_discard_framebuffer GL_OES_get_program_binary GL_ARM_mali_program_binary GL_EXT_shader_texture_lod GL_EXT_robustness GL_OES_depth_texture_cube_map GL_KHR_debug
EGL:
EGL_KHR_image EGL_KHR_image_base EGL_KHR_image_pixmap EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_fence_sync EGL_ANDROID_image_native_buffer EGL_ANDROID_recordable EGL_ANDROID_native_fence_sync EGL_ANDROID_framebuffer_target EGL_EXT_create_context_robustness EGL_ANDROID_blob_cache

seems like there are more shadow glitches than just directional on master
(eg. spot light on both 3.1.1 and 3.2)

[clayjohn]

I wonder if this has the same cause as https://github.com/godotengine/godot/issues/33825

@avril-gh Can you check out this PR and see if it helps? https://github.com/akien-mga/godot/pull/4

[avril-gh]

@clayjohn

directional on gles2 mali450

omni on gles2 mali450

spot on gles2 mali450

device caps

Android GLES: ARM, Mali-450 MP, OpenGL ES 2.0
GL_EXT_debug_marker GL_OES_texture_npot GL_OES_compressed_ETC1_RGB8_texture GL_OES_standard_derivatives GL_OES_EGL_image GL_OES_depth24 GL_ARM_rgba8 GL_ARM_mali_shader_binary GL_OES_depth_texture GL_OES_packed_depth_stencil GL_EXT_texture_format_BGRA8888 GL_OES_vertex_half_float GL_EXT_blend_minmax GL_OES_EGL_image_external GL_OES_EGL_sync GL_OES_rgb8_rgba8 GL_EXT_multisampled_render_to_texture GL_EXT_discard_framebuffer GL_OES_get_program_binary GL_ARM_mali_program_binary GL_EXT_shader_texture_lod GL_EXT_robustness GL_OES_depth_texture_cube_map GL_KHR_debug
EGL:
EGL_KHR_image EGL_KHR_image_base EGL_KHR_image_pixmap EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_fence_sync EGL_ANDROID_image_native_buffer EGL_ANDROID_recordable EGL_ANDROID_native_fence_sync EGL_ANDROID_framebuffer_target EGL_EXT_create_context_robustness EGL_ANDROID_blob_cache

tested on project
DirectionalLight_shadow.zip

[akien-mga]

I can confirm that #33844 fixes it on Samsung Galaxy S3 (as @avril-gh just did, nice timing :)).

[avril-gh]

directional light seems ok, but what with this spotlight ?

[akien-mga]

@avril-gh According to your previous screenshots it's the same as in 3.1.1, so it's a different bug and not a regression.