Godot: VideoPlayer set_stream_position not work

[DimaKiva]

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Ubuntu 16.04, Godot 3.0 beta 1

Steps to reproduce:
set_stream_position(20.0)

[akien-mga]

What kind of VideoStream are you playing? This bug report doesn't provide enough information, please try to be more specific.

[akien-mga]

• VideoPlayer::set_stream_position calls VideoStreamPlayback::seek: https://github.com/godotengine/godot/blob/86ed07c/scene/gui/video_player.cpp#L378
• It's a virtual method which has to be defined in each VideoStreamPlayback implementation: https://github.com/godotengine/godot/blob/03a0805/scene/resources/video_stream.h#L59
• We currently support Theora and WebM, both of which have a non-implemented seek method. Implementing it for both formats should solve this issue.
  
  
  
  • https://github.com/godotengine/godot/blob/3edd3cd/modules/theora/video_stream_theora.cpp#L636-L639
  
  
  • https://github.com/godotengine/godot/blob/13c2ff9/modules/webm/video_stream_webm.cpp#L222-L225
  
  

[DimaKiva]

Example
https://github.com/godotengine/godot/files/1503680/Bug.video.zip

[hungrymonkey]

i am just looking around to see how to add seek to ogg.

looks pretty complicated

http://blog.pearce.org.nz/2009/05/video-seeking-improvements.html

i am debating whether or not to try to fix it since i kinda want to understand how ogg works

[blurymind]

@hungrymonkey would it be easier to implement for webm?

[hungrymonkey]

@blurymind probably somewhat the same difficulty.

you have to seek to find keyframes. The code doesnt really separate grabbing frames and finding the keyframe.

[Galileo53]

I would like to give this problem a push.
It would be really great if the seek function could be implemented.
Godot 3.1 ?

[zszen]

godot 3.1.1 same bug

[hungrymonkey]

I do not think libsimplewebm supports seeking.

[hungrymonkey]

@akien-mga I attempted to implement ogg theora seek support but I do not understand why the video just waits for the full seek as if the player wants to catch up although I submitted zero frames.
https://github.com/hungrymonkey/godot/tree/seek_theora
Can somebody tell me why?
Nevermind, I found it. Play() resets the time

[hungrymonkey]

I never realize force pushing would lead to such spam. Opps.

[CrimsonZA]

set_stream_position method is still not functioning in Godot 3.2 beta 4

[hungrymonkey]

@CrimsonZA Godot already have a ffmpeg decoder for all codecs
https://github.com/kidrigger/godot-videodecoder

[CrimsonZA]

seems like Godot isn't ready to play video on Android, at least not on an Oculus Go, definitely not for immersive vide using the built in vide player node or godot-videodecoder

[hungrymonkey]

@CrimsonZA You can try my seek theora branch which might end up in Godot 4.0. You have to compile in support for it. Tell me if I have any bugs.

[arsen-ch]

@CrimsonZA Godot already have a ffmpeg decoder for all codecs
https://github.com/kidrigger/godot-videodecoder

Does it support seek function?

[hungrymonkey]

@arsen-ch Seek function looks empty? https://github.com/kidrigger/godot-videodecoder/blob/master/src/gdnative_videodecoder.c#L693

[Tooniis]

How about removing this property until the seek functions are implemented?

[Calinou]

@Tooniis Removing properties is technically a breaking change (even if they were never working well in the first place), so we can't do it in the 3.2 branch. For properties, we can hide them from the editor (like for contact shadows), but we can't do that for methods.