Godot: TileMap Editor does not function properly

[gururise]

Godot 3.0 - Linux

Issue description:
Placing tiles on a Tilemap in the editor is bugged.

Steps to reproduce:

1. Create Tileset
2. Create new scene with tilemap, and use the tileset above as the texture.

When placing tiles, after you let go of the mouse button, about half the tiles disappear. With every subsequent click and release of the left mouse button on the tilemap, more tiles randomly disappear:

[vnen]

cc @MarianoGnu

[MarianoGnu]

holy sh...

[CyanBlob]

@MarianoGnu I saw this behavior as well a couple of days ago. I'm not sure exactly what caused it, but it wasn't happening last night when I tested it again. I'll see if I can figure out what the cause is tonight, but I don't have much time.
@gururise Does this happen for you all the time, even with different tilesets/tilemaps?

[PJB3005]

I also think it got fixed very recently, let me check.

[gururise]

@CyanBlob I just pulled and built a new build today.

I created a brand new tileset & tilemap (new project) and got the same results so it seems like the bug is not fixed:

I am using tilesizes of 32x32 if it make any difference. I am also on Linux.

Attached is the sample project.
tileProject.zip

[PJB3005]

Ok, so I just checked. The bug only seems to happen just after creating the TileMap node. Closing and re-opening the scene seems to fix it permanently.

[CyanBlob]

I can confirm @PJB3005's comment after some brief testing. After adding a new TileMap node, the bug occurs until the scene is reloaded (I used Scene->Revert Scene to test).
I also occasionally got this error:
scene/resources/tile_set.cpp:394 - Condition ' !tile_map.has(p_id) ' is true. returned: false
Which is inside the TileSet::tile_get_is_autotile function

[MarianoGnu]

@PJB3005 @CyanBlob i'm very sure of the cause of this bug is the code i wrote to allow open 2.1 tilemaps.
https://github.com/godotengine/godot/blob/master/scene/2d/tile_map.cpp#L963
https://github.com/godotengine/godot/blob/master/scene/2d/tile_map.cpp#L1012

adding this line to get_tile_data() might fix it.
format = FORMAT_2_1_5;
will give it a look if i get some spare time, meanwhile, hero wanted!

[akien-mga]

What are those 2_1_4 and 2_1_5 formats? The numbers seem kind of arbitrary, shouldn't it be FORMAT_1 and FORMAT_2?

[MarianoGnu]

they are on tile_map.h, i didn't know how to name them but since they are not exposed to gdscript it doesn't matter, they can be renamed anytime.

[CyanBlob]

Alright, I opened a PR with the change @MarianoGnu suggested and can confirm that it did fix the issue. I also renamed the DataFormat enum members per @akien-mga

[gururise]

Can also confirm the PR submitted by @CyanBlob fixed the issue.

[akien-mga]

Fixed by #14454.