Godot: autotile editor - collisions- selecting trash tool while making a shape with shape edit tool causes godot to crash

[blurymind]

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Windows10 64 Activated GL 3.3 contextOpenGL ES 3.0 Renderer: GeForce GTX 1060/PCIe/SSE2

Issue description:

Godot crashed

Steps to reproduce:

1. Start making a shape in the autotile editor's collisions tab- using the shape tool.
2. Click at least 3-4 times to add points...Before closing the shape, click on the trash tool

Godot will crash entirely
If it doesnt happen the first time- try it a few times on different squares

Console log:

F:\stuff\godot>Activated GL 3.3 contextOpenGL ES 3.0 Renderer: GeForce GTX 1060/PCIe/SSE2
GLES3: max ubo light: 409
GLES3: max ubo reflections: 455, ubo size: 144
ARVR: Registered interface: Native mobile
ERROR: EditorData::get_edited_scene_root: Indexcurrent_edited_scene=-1 out of size (edited_scene.size()=0)
   At: editor\editor_data.cpp:607
erasing C:\Users\blury\AppData\Roaming/Godot/projects/godot3-addons-0d566e2f5a7ea3c5ae308e29c618e322/filesystem_update3
ERROR: VisualServerCanvas::canvas_item_add_polygon: Condition ' pointcount < 3 ' is true.
   At: servers\visual\visual_server_canvas.cpp:638
ERROR: VisualServerCanvas::canvas_item_add_polygon: Condition ' pointcount < 3 ' is true.
   At: servers\visual\visual_server_canvas.cpp:638
ERROR: VisualServerCanvas::canvas_item_add_polygon: Condition ' pointcount < 3 ' is true.
   At: servers\visual\visual_server_canvas.cpp:638
ERROR: VisualServerCanvas::canvas_item_add_polygon: Condition ' pointcount < 3 ' is true.
   At: servers\visual\visual_server_canvas.cpp:638
ERROR: VisualServerCanvas::canvas_item_add_polygon: Condition ' pointcount < 3 ' is true.
   At: servers\visual\visual_server_canvas.cpp:638
ERROR: VisualServerCanvas::canvas_item_add_polygon: Condition ' pointcount < 3 ' is true.
   At: servers\visual\visual_server_canvas.cpp:638
ERROR: VisualServerCanvas::canvas_item_add_polygon: Condition ' pointcount < 3 ' is true.
   At: servers\visual\visual_server_canvas.cpp:638
ERROR: VisualServerCanvas::canvas_item_add_polygon: Condition ' pointcount < 3 ' is true.
   At: servers\visual\visual_server_canvas.cpp:638
ERROR: VisualServerCanvas::canvas_item_add_polygon: Condition ' pointcount < 3 ' is true.
   At: servers\visual\visual_server_canvas.cpp:638
ERROR: VisualServerCanvas::canvas_item_add_polygon: Condition ' pointcount < 3 ' is true.
   At: servers\visual\visual_server_canvas.cpp:638
ERROR: VisualServerCanvas::canvas_item_add_polygon: Condition ' pointcount < 3 ' is true.
   At: servers\visual\visual_server_canvas.cpp:638
ERROR: VisualServerCanvas::canvas_item_add_polygon: Condition ' pointcount < 3 ' is true.
   At: servers\visual\visual_server_canvas.cpp:638
ERROR: VisualServerCanvas::canvas_item_add_polygon: Condition ' pointcount < 3 ' is true.
   At: servers\visual\visual_server_canvas.cpp:638
ERROR: VisualServerCanvas::canvas_item_add_polygon: Condition ' pointcount < 3 ' is true.
   At: servers\visual\visual_server_canvas.cpp:638
ERROR: VisualServerCanvas::canvas_item_add_polygon: Condition ' pointcount < 3 ' is true.
   At: servers\visual\visual_server_canvas.cpp:638
ERROR: VisualServerCanvas::canvas_item_add_polygon: Condition ' pointcount < 3 ' is true.
   At: servers\visual\visual_server_canvas.cpp:638
ERROR: PoolVector<struct Vector2>::operator []: FATAL: Indexp_index=-1 out of size (size()=0)
   At: d:\build\godot\godot\core\dvector.h:504
CrashHandlerException: Program crashed
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[0] PoolVector<Vector2>::operator[] (d:\build\godot\godot\core\dvector.h:504)
[1] AutotileEditor::draw_polygon_shapes (d:\build\godot\godot\editor\plugins\tile_set_editor_plugin.cpp:1238)
[2] AutotileEditor::_on_workspace_draw (d:\build\godot\godot\editor\plugins\tile_set_editor_plugin.cpp:635)
[3] MethodBind0<AutotileEditor>::call (d:\build\godot\godot\core\method_bind.gen.inc:139)
[4] Object::call (d:\build\godot\godot\core\object.cpp:913)
[5] Object::emit_signal (d:\build\godot\godot\core\object.cpp:1194)
[6] Object::emit_signal (d:\build\godot\godot\core\object.cpp:1240)
[7] CanvasItem::_update_callback (d:\build\godot\godot\scene\2d\canvas_item.cpp:330)
[8] MethodBind0<CanvasItem>::call (d:\build\godot\godot\core\method_bind.gen.inc:139)
[9] Object::call (d:\build\godot\godot\core\object.cpp:913)
[10] MessageQueue::_call_function (d:\build\godot\godot\core\message_queue.cpp:259)
[11] MessageQueue::flush (d:\build\godot\godot\core\message_queue.cpp:306)
[12] SceneTree::iteration (d:\build\godot\godot\scene\main\scene_tree.cpp:462)
[13] Main::iteration (d:\build\godot\godot\main\main.cpp:1691)
[14] OS_Windows::run (d:\build\godot\godot\platform\windows\os_windows.cpp:2114)
[15] widechar_main (d:\build\godot\godot\platform\windows\godot_win.cpp:149)
[16] _main (d:\build\godot\godot\platform\windows\godot_win.cpp:171)
[17] main (d:\build\godot\godot\platform\windows\godot_win.cpp:183)
[18] __scrt_common_main_seh (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283)
[19] BaseThreadInitThunk
-- END OF BACKTRACE --

@MarianoGnu might be interested in this one

[MarianoGnu]

i could not reproduce it, this is happening in the draw event, trying to draw an invalid polygon, that's all i know. maybe you had many points in the same location?

[blurymind]

Its a little hard to get it to crash. I will try to do it and record the steps to reproduce

[blurymind]

I got it! The crash happens if you have more than one shapes inside the tile and click on the delete button: