Godot: Improve conversion of scenes and resource files to binary on export

[NullNeska]

Apologies if this is the wrong place, but is this feature being implemented in 3.0 as well as exporting resources into the exe on export?

[akien-mga]

This is already done automatically.

[NullNeska]

exporting my projects PCKs when opened in notepad++ show half binary half raw text, the raw text is my scripts and tscns

sorry i should of been more clear, the resources being converted on export.

[reduz]

Ah, this needs to be redone in 3.0

On Oct 28, 2017 9:55 AM, "Neska" [e-mail] wrote:

exporting my projects PCKs when opened in notepad++ show half binary half
raw text, the raw text is my scripts and tscns

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/12452#issuecomment-340188931,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z29CfE_V9PXA_78paZgofyw92Bkytks5swyQvgaJpZM4QJ1oG
.

[NullNeska]

Could this be completed before the first beta release??

[reduz]

No, no time, will be pushed for 3.1

On Sun, Nov 26, 2017 at 11:23 AM, Neska [e-mail] wrote:

Could this be completed before the first beta release??

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/12452#issuecomment-347011949,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z289gT6eMumI0RGv6WliUBA5KLPCpks5s6XR7gaJpZM4QJ1oG
.

[NullNeska]

so 3.0 is going to have easily exploitable game release?

[reduz]

@NullNeska yes, but I doubt any game started with 3.0 (with enough work put on it so this is a concern), will ship before 3.1 anyway.

[NullNeska]

I suppose you are right, i guess im not taking into account how much sooner a 3.1 release would be compared to 2.1 to 3.0.

[Calinou]

so 3.0 is going to have easily exploitable game release?

Binary scene conversion should not be viewed as a "protection" tool, but rather as a way to speed up scene loading (as binary scenes are faster to parse than text-based scenes; the files also are smaller).

[williamd1k0]

@akien-mga changed the title from Convert to binary on export [3.0] to Convert tscn to binary on export on Aug 15

I think this should be "Convert scenes and resource files to binary on export" to cover #6709 as well.

[reduz]

Actually this is implemented already but disabled by default because it was buggy, wonder if anyone wants to give it a try (its on the project settings somewhere).

[williamd1k0]

Indeed, there is a project setting in editor section:

[editor]
convert_text_resources_to_binary_on_export=true

In this case, if I enable this option, will it work with bugs or it does nothing?

[reduz]

It will work with (maybe) bugs

[williamd1k0]

I see, in this case the issue title should be "Improve conversion of scenes and resource files to binary on export" or something like that.

[aarongerber]

Looking forward to this... still on track for 3.1?

[akien-mga]

We ran out of time to implement new features for 3.1, so it will have to wait for 3.2. If it's implemented during 3.2 development, it might still be cherry-picked to a 3.1.x release though.

But this issue is pretty vague, and since the feature apparently exists already (albeit opt-in), the most useful would be to have users testing it and report bugs if they experience any.

[girng]

@williamd1k0 i tested the convert_text_resources_to_binary_on_export on 9ba6849cf4191e1c037e7416d21f28b19e0e5f43, doesn't seem like it's working yet. i checked .pck with vscode and could see raw gds in there

[williamd1k0]

@girng I think this is not related to gdscript, only .tres and .tscn

[girng]

@williamd1k0 yep, my bad. edited prev post