Godot: Exclamation point ( ! ) from DroidSans looks strange in output

Created on 11 Jul 2016  Â·  29Comments  Â·  Source: godotengine/godot

Ubuntu 14.04 64-bit

func _ready():
    print("!")
    print("!!!")

image

bug confirmed pr welcome editor

Most helpful comment

DroidSans
font_sans
NotoSans-Regular
font_noto

what about changing default ttf then?

image

All 29 comments

Can confirm in the inspector as well.

Should be fixed for 2.1, it looks too weird :)

well, it's the font fault, anyone graphically wise up for some fontforge editing?

BTW, the Droid Sans font is under the Apache 2.0 license, so if we ever edit it (I guess we already did?), we need to make it crystal clear somewhere that this is not the original version (the Apache 2.0 license is pretty clear about that).

I haven't done any editing to it, currently we are using the pristine TTF files, as we implemented fallbacks

Thanks for the precision :)

I don't think that it's the font's fault; I don't imagine a font like Google's DroidSans having such a bad rendering for its exclamation mark in 14pt.

Here's a comparison in zoom 100% and 800% of:

  • above: a Label using a DynamicFont with our tools/editor_fonts/DroidSans.ttf loaded, size 14pt
  • below: a Label using the default font
  • on the right: the same font (supposedly) in the Output panel (the zoomed version is actually upscaled in GIMP with no interpolation)

Zoom 100%: spectacle xv4312 spectacle tj4312

Zoom 800%:
spectacle du4312
spectacle tj4312

Also interesting to note: the font is not rendered the same in LineEdit / TextEdit / Label in the game's viewport (whether in-game or in the 2D viewport) as in the editor's docks:

Zoom 100%:
spectacle gx4312
spectacle tj4312

Zoom 800% (upscaled in GIMP, no interpolation):
spectacle gx4312
spectacle tj4312

This might be related to #5663.

As shown by my above screenshots, with FreeType 2.6.5 it looks less ugly, though it's still not perfect. Moving to the 2.2 milestone as it's no longer critical for 2.1 IMO - but we should still investigate the various FreeType options at our disposal to see if this could be improved.

Pretty bump, what's going on with this issue (and is it somehow fixed too)?

(and is it somehow fixed too)

Not fixed yet, though it has been worse: spectacle x12488

DroidSans
font_sans
NotoSans-Regular
font_noto

what about changing default ttf then?

image

noto sans is pretty, but it's huge

On Mon, Jul 31, 2017 at 5:49 AM, volzhs notifications@github.com wrote:

DroidSans
[image: font_sans]
https://user-images.githubusercontent.com/8281454/28769720-97645006-7617-11e7-9f12-93749c20b88b.png
NotoSans-Regular
[image: font_noto]
https://user-images.githubusercontent.com/8281454/28769722-98fec4f0-7617-11e7-81a1-a6a79745fe06.png

what about changing default ttf then?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/5647#issuecomment-319006912,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z2_v1Qr3YL2DlkT1ZoltxtQSQyq6-ks5sTZUPgaJpZM4JJbi3
.

@reduz current droidsans.ttf is 190kB and notosans-regular size is 305.9kB.
I think it's still small.

@reduz I meant that I suggested replacing DroidSans.ttf only to NotoSans-Regular.ttf, not others.

you mean mixing them? does that even work? :D

On Mon, Jul 31, 2017 at 9:27 AM, volzhs notifications@github.com wrote:

@reduz https://github.com/reduz I meant that I suggested replacing
DroidSans.ttf only to NotoSans-Regular.ttf, not others.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/5647#issuecomment-319052705,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z2_1sotr11Nyyb1qhsYiv46lSEPJRks5sTcgTgaJpZM4JJbi3
.

image

@reduz it seems to work well :)

Couldn't that be something tweakable at the FreeType level?

El 31 jul. 2017 2:35 p. m., "volzhs" notifications@github.com escribió:

[image: image]
https://user-images.githubusercontent.com/8281454/28777941-2012d146-7638-11e7-93fb-f64594963430.png

@reduz https://github.com/reduz it seems to work well :)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/5647#issuecomment-319054434,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALQCtjlvFMbjRGsYRS0x2qP2XeNHc-GSks5sTcongaJpZM4JJbi3
.

Seems a bit over-complex doesn't it?

I'm using 2.1.4 editor with NotoSans-Regular.ttf for default font.
Almost everything seems fine but title bar height should be handled in a proper way.

image

Are you using Intel drivers @volzhs? If so, bear #8902 in mind.

@Sslaxx it's not that case and I'm using GeForce GTX 670 with nvidia-375 driver on ubuntu 16.04.
The Title bar height I mentioned above is about popup window title in editor.
"Create New Node" in this screenshot.

can this be closed now?

\o/

On Thu, Aug 31, 2017 at 10:03 AM, volzhs notifications@github.com wrote:

can this be closed now?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/5647#issuecomment-326288512,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z20phH9TxGMBTavoyVTOZgRP-FIaXks5sdq8MgaJpZM4JJbi3
.

I'd take this as an "yes". Obsoleted by #10690.

Or wait, no. That was PRed to the 2.1 branch.

it's finally closed. :open_mouth:

Edit: oh.. it's not... :disappointed:
@bojidar-bg we have #10814 also but not merged yet.

Well now fixed for real :)

Was this page helpful?
0 / 5 - 0 ratings