Go: net/http: another typo in Response.Body field docs

Created on 4 Aug 2019  路  9Comments  路  Source: golang/go

What version of Go are you using (go version)?

$ go version
go1.12.7 windows/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output

$ go env
GOARCH=amd64
GOOS=windows

What did you do?

Read the documentation in file: ~/src/net/http/response.go
Found grammatical issue in field Body of struct Response, around line 68

What did you expect to see?

// As of Go 1.12, the Body will also implement io.Writer

What did you see instead?

// As of Go 1.12, the Body will be also implement io.Writer

Documentation FrozenDueToAge NeedsFix help wanted

Most helpful comment

@shivi28 don't worry, this was a classic go race condition :-)
It was going to be my first contribution but I took too much time on the "contribute" document (basically trying to decide if I should use my @gmail or Google Suite account to sign the CLA and setting up gcc on Windows for the all.bat test to pass, though strictly wasn't necessary for a simple comment change) that I realized you beat me to it.
After n-number of languages I am having a lot of fun with Go, so let's keep having fun!

All 9 comments

Good catch! Would you like to submit a change for this (https://golang.org/doc/contribute.html)? Also (let's see if this works), @gopherbot, add NeedsFix, "help wanted", Documentation.

Sure, would love to! Thanks.

Change https://golang.org/cl/188541 mentions this issue: net/http : fixed typo in Body part of net/http response.go

Hello @agnivade @sanjib I tried to solve this issue.

Thank you for filing this issue @sanjib and welcome to the Go project! Thank you for the triage @smasher164 too and for chiming in @shivi28!

Hello @agnivade @sanjib I tried to solve this issue.

I had just posted feedback on your CL @shivi28 and on coming here noticed that @sanjib had already committed to it. @sanjib sorry about that, but could you please perhaps let @shivi28 take this one as they already have the CL out, and in the future @shivi28 please take a look at who has responded in case they are already working on the fix :)

@odeke-em hey no problem, thanks! :-)

Sure @odeke-em I will keep this in mind and I extremely apologize for this @sanjib

@shivi28 don't worry, this was a classic go race condition :-)
It was going to be my first contribution but I took too much time on the "contribute" document (basically trying to decide if I should use my @gmail or Google Suite account to sign the CLA and setting up gcc on Windows for the all.bat test to pass, though strictly wasn't necessary for a simple comment change) that I realized you beat me to it.
After n-number of languages I am having a lot of fun with Go, so let's keep having fun!

@sanjib - Don't worry, you are now done with your setup, and this issue tracker will keep having new issues. And I'm pretty sure if you go through old issues searching for "Documentation"/ "help wanted"/ "suggested" labels, you can find something that you feel comfortable contributing to. See this for more info.

Was this page helpful?
0 / 5 - 0 ratings