Go: x/tools/gopls: support all features on the command line

[stamblerre]

gopls features like find references, rename, etc. should work on the command line. Support for them should be added to internal/lsp/cmd. Right now, only definition and format are supported.

[hartzell]

If no one's working on it, I'll take a swing at adding rename. Looks like it's a matter of adding an internal/lsp/cmd/rename.go that defines a type rename struct {...} and fleshing out a Run method for it. Looks like the rename machinery wants to work from a position, seems like I can mimic/steal what the query definition subcommand uses. Anything I'm missing?

[hartzell]

I'll take a swing at adding rename

This has been merged, see https://github.com/golang/tools/pull/157. Great support for a first time contributor.

[rentziass]

If no one's on it, I'd give references a spin 😊

[stamblerre]

@rentziass: Absolutely, please do! Feel free to reach out with any questions here or on the Gophers Slack (https://invite.slack.golangbridge.org/).

[kalmanb]

@stamblerre any others need implementation?

[stamblerre]

Anything that doesn't have a test in this file is available: https://github.com/golang/tools/blob/e4d7c6f25b8e08c4784d6585835a053ae0ad53bb/internal/lsp/cmd/test/cmdtest.go#L41. I would suggest Import or SuggestedFix as a useful next feature.

[kalmanb]

Great, thanks I'll SuggestedFix a go.

[gopherbot]

Change https://golang.org/cl/202178 mentions this issue: tools/gopls: add cmd support for references

[gopherbot]

Change https://golang.org/cl/202480 mentions this issue: tools/gopls: add command line support for suggestedfix

[kalmanb]

I'll also take a look at Import and Link

[gopherbot]

Change https://golang.org/cl/202624 mentions this issue: tools/gopls: add command line support for imports

[rentziass]

I'll keep going with SignatureHelp and Symbol then :)

[gopherbot]

Change https://golang.org/cl/203297 mentions this issue: tools/gopls: add command line support for imports

[gopherbot]

Change https://golang.org/cl/203609 mentions this issue: tools/gopls: add cmd support for symbols

[gopherbot]

Change https://golang.org/cl/204057 mentions this issue: tools/gopls: add cmd support for signature

[rentziass]

Continuing with FoldingRange and Highlight if no one's on them!

[gopherbot]

Change https://golang.org/cl/206158 mentions this issue: tools/gopls: add cmd support for folding_ranges

[rhnvrm]

Taking up prepare_rename

[gopherbot]

Change https://golang.org/cl/207579 mentions this issue: tools/gopls: add cmd support for prepare_rename

[gopherbot]

Change https://golang.org/cl/207291 mentions this issue: tools/gopls: add cmd support for highlight

[rentziass]

Moving on to Completion

[jbszczepaniak]

I will jump into Implementation

[gopherbot]

Change https://golang.org/cl/208357 mentions this issue: tools/gopls: add cmd support for implementation

[jbszczepaniak]

I will jump into Highlight

[stamblerre]

@jbszczepaniak: I believe that Highlight has already been handled by https://go-review.googlesource.com/c/tools/+/207291. I just haven't had a chance to review it yet.

[jbszczepaniak]

O, I see, right. It seems that these are yet to be done:

• Completion
• CompletionSnippet
• UnimportedCompletion
• DeepCompletion
• FuzzyCompletion
• CaseSensitiveCompletion
• RankCompletion

I will take from the list - Completion

[rentziass]

@jbszczepaniak I'm currently working on Completion, see a couple of comments above :)

[jbszczepaniak]

🤦‍♂ ok. I believe this is a list (right?):

• ~CompletionSnippet~
• UnimportedCompletion
• DeepCompletion
• FuzzyCompletion
• CaseSensitiveCompletion
• RankCompletion

Thus I will take CompletionSnippet

[stamblerre]

@rentziass: Do you intend to add all of the completion related test code in your CL? In that case, I believe that this issue could be considered done.

[rentziass]

I'd surely like to try :)

[jbszczepaniak]

O, In that case I will move to something else.

On 22 Nov 2019, at 17:33, Francesco Renzi [e-mail] wrote:

I'd surely like to try :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/golang/go/issues/32875?email_source=notifications&email_token=ADREANDBLCOVT5MRW6ICHRTQVACVTA5CNFSM4H4U2ROKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE6FFUI#issuecomment-557601489, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADREANAYSF55LGFBQH2EESDQVACVTANCNFSM4H4U2ROA.

[daisuzu]

I'll do workspace/symbol.

[gopherbot]

Change https://golang.org/cl/224677 mentions this issue: tools/gopls: add cmd support for workspace_symbol