Go: cmd/go/internal/txtar: no escaping for file separator
The txtar file format is simple, but too simple. For example, an archive containing the file go/src/cmd/go/internal/txtar/archive_test.go itself will not round-trip correctly, because that file contains literals that look like file separators.
The spec should include an escaping/quoting scheme.
gaal
All 3 comments
Personally, I like the ultra-simple nature of the file format, although it's true that sometimes you do want to have a file that contains the separators. That's possible to work around, however. In this fork of testscript, I've provided unquote as a standard primitive. It just removes the leading > from the start of each line. I also changed the txtar-c command so that you can ask it to do the quoting for you.
Perhaps that approach might work for the internal testscript code too.
rogpeppe
on 13 May 2019
@jayconrod @bcmills
andybons
on 13 May 2019
Agree with @rogpeppe, the simplicity of this format is really valuable. I'd rather not add features to it.
@ianthehat mentioned another case that doesn't roundtrip correctly: files that don't end with a newline. As with the unquote feature above, he recommends processing these files before and after packing them into txtar (adding newlines to files before packing, removing newlines after).
jayconrod
on 30 May 2019
Related issues
go101
路
3Comments
natefinch
路
3Comments
longzhizhi
路
3Comments
michaelsafyan
路
3Comments
bradfitz
路
3Comments
Most helpful comment
Personally, I like the ultra-simple nature of the file format, although it's true that sometimes you do want to have a file that contains the separators. That's possible to work around, however. In this fork of testscript, I've provided
unquoteas a standard primitive. It just removes the leading>from the start of each line. I also changed thetxtar-ccommand so that you can ask it to do the quoting for you.Perhaps that approach might work for the internal testscript code too.