Go: x/tools/cmd/gopls: GoToDef does not work with embedded pointer structs

[marwan-at-work]

Say you have a struct that looks like this:

type A struct {}

type B struct {
    *A
}

If you tried to GoToDef on the embedded struct *A inside B, then the GoToDef does not work. But if you remove the *, then GoToDef works properly by moving the cursor to the A declaration

cc: @ianthehat

[muirdm]

I'll work on this one if it is still available.

[stamblerre]

It is available. Thanks!

[ianthehat]

Although Marwan did mention he might decide to look at himself, not sure if he still means to or not?
I believe this is probably related to the special handling for embedded fields here

[gopherbot]

Change https://golang.org/cl/172583 mentions this issue: internal/lsp: handle embedded struct point definitions

[marwan-at-work]

@muirrn you beat me to it so it's all yours :)

[muirdm]

Oops, didn't mean to step on anyone's toes.