In https://github.com/stellar/go/pull/635#discussion_r215681206, @bartekn says that this codebase wants to move away from GoConvey. I 100% support this direction, so here's an issue to discuss and track progress on that.
We might start opening pull requests to convert tests if that would make sense!
kr
All 5 comments
Go Convey should be completely removed now
lechengfan
on 26 Sep 2018
🎉2
Nice!
kr
on 2 Oct 2018
Can you also remove it from Gopkg.lock?
bartekn
on 4 Oct 2018
Isn't Gopkg.lock something that's automatically generated by dep ensure -v? As in when users run dep ensure for the first time, it'll get rid of the convey deps
lechengfan
on 4 Oct 2018
I mean we should regenerate it so that running dep ensure after cloning the repo doesn't make any changes to the working directory.
bartekn
on 4 Oct 2018
👍1
Was this page helpful?
0 / 5 - 0 ratings
Related issues
aanupam23
路
6Comments
Synesso
路
4Comments
bartekn
路
7Comments
bartekn
路
3Comments
tomerweller
路
4Comments
Most helpful comment
Go Convey should be completely removed now