Go: proposal: database/sql: Extend the DBStats struct

[frojasg]

The method db.Stats() exposes the DBStats struct that only has the number of connection open.
I would like to include:

• The number of active connections: db.numOpen - len(db.freeConn)
• The number of connection requests: len(db.connRequests)

[derekperkins]

This would be great to export as a metric. We don't have any insight into what the right size of our connection pools should be, and it's even harder to debug delays when we think that queries are waiting for an open connection.

[kardianos]

Please inspect tip: https://tip.golang.org/pkg/database/sql/#DBStats

Does this solve your need?

[derekperkins]

That's perfect. Thanks @kardianos!

[frojasg]

yep, that looks good to me

[frojasg]

is this going to be included in go 1.11? I don't see it here https://tip.golang.org/doc/go1.11

[kardianos]

It will be in go1.11.

I didn't put it in the release notes.