Go: cmd/go: go get github.com/rsc/vgotest5 fails
go get github.com/rsc/vgotest5 should work with the latest Go 1.9 release branch yet does not. rsc to fix.
/cc @andybons
rsc
All 11 comments
@gopherbot backport Go 1.9 Go 1.10
This is actually present everywhere; you just have to start with nothing in GOPATH and ask for vgotest5 directly (without doing vgotest4 first).
rsc
on 1 Jun 2018
@gopherbot PLEASE backport Go 1.9 Go 1.10
rsc
on 1 Jun 2018
Backport issue(s) opened: #25690 (for 1.10), #25691 (for 1.9).
Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.
gopherbot
on 1 Jun 2018
(Seriously? We've gone full-on Jurassic Park? What purpose does this serve?)
rsc
on 1 Jun 2018
When the robot uprising inevitably occurs we can at least say we were polite to their ancestors.
andybons
on 1 Jun 2018
Getting off-topic for this issue but the best technical rationale I can see is that having an indicator word beyond the @-reference avoids false triggering the bot, so that it wouldn't trigger on someone saying "why did (AT)gopherbot backport that CL?". Otherwise you're just playing simon says for no good reason.
rsc
on 1 Jun 2018
Change https://golang.org/cl/115797 mentions this issue: cmd/go: fix 'go get' compatibility for direct download of vgo-aware module
gopherbot
on 1 Jun 2018
@FiloSottile for the gopherbot semantics. If we want to continue this conversation let’s start a new issue.
andybons
on 2 Jun 2018
I indeed came up with it as a false positive mitigation for such a high-touch action with cases like you mentioned in mind, but I'll admit I did not consider alternatives because I do like the idea of having to be nice in comments, even to the bot.
Opened #25700 for documenting @gopherbot actions.
FiloSottile
on 2 Jun 2018
Change https://golang.org/cl/116175 mentions this issue: [release-branch.go1.9] cmd/go: fix 'go get' compatibility for direct download of vgo-aware module
gopherbot
on 4 Jun 2018
Change https://golang.org/cl/116176 mentions this issue: [release-branch.go1.10] cmd/go: fix 'go get' compatibility for direct download of vgo-aware module
gopherbot
on 4 Jun 2018
Related issues
bbodenmiller
·
3Comments
jayhuang75
·
3Comments
michaelsafyan
·
3Comments
Miserlou
·
3Comments
myitcv
·
3Comments
Most helpful comment
(Seriously? We've gone full-on Jurassic Park? What purpose does this serve?)