Go-ipfs: Enable Gateway on localhost IPv6 (ip4+ip6 by default)

[lidel]

Version information:

0.4.18

Type:

enhancement

Description:

What? How do we feel about migrating default Gateway config to listen on ipv6 as well?
For now, this can be enabled manually via:

$ ipfs config --json Addresses.Gateway '["/ip4/127.0.0.1/tcp/8080","/ip6/::1/tcp/8080"]'

Why? It is a cosmetic change that enables much shorter URLs for local gateway and shift focus towards IPFS paths:

How?

Current default:

$ ipfs config --json Addresses.Gateway
/ip4/127.0.0.1/tcp/8080

Proposed change (arrays are supported since https://github.com/ipfs/go-ipfs-config/pull/11):

$ ipfs config --json Addresses.Gateway
[
  "/ip4/127.0.0.1/tcp/8080",
  "/ip6/::1/tcp/8080"
]

Additional notes:

• To avoid socket: address family not supported by protocol error on systems without ipv6 we go-ipfs could detect runtime without ipv6 and ignore multiaddrs starting with /ip6/, as suggested in https://github.com/ipfs/go-ipfs/issues/1675#issuecomment-139111308
• Investigating vanity hostnames for localhost HTTP gateway: https://github.com/ipfs/in-web-browsers/issues/109
  
  
  
  • tl;dr
  
  

AFAIK only 127.0.0.1 and ::1 are whitelisted by browser vendors (eg. firefox #903966) while localhost is not (that is why Companion uses raw IP)

[Stebalien]

We should definitely listen on both. Mind making a PR?

[alanshaw]

...also to JS IPFS 🙏

[da2x]

For what it’s worth, I’ve been running my local gateway on [::1] for almost a year with no issues.

[Kubuxu]

@Stebalien We can include it in upcoming migration, what do you think?

[Stebalien]

SGTM (iff the user is already listening on 127.0.0.1).