Go-ipfs: Fixup the p2p command

Created on 29 Mar 2018  路  1Comment  路  Source: ipfs/go-ipfs

This command looks like it could use some serious cleanup.

  1. Listeners have Running flags that are (1) never set to false, and (2) not atomic (so setting them to false would be useless anyways).
  2. The registry has no synchronization and is pretty inefficient.

And probably more. Any takers?

help wanted kinbug
Source
picture Stebalien

Most helpful comment

More: Make it actually work like ssh -L. It should forward every connection, not just the first. See https://github.com/ipfs/go-ipfs/pull/4894#issuecomment-377287053.

picture Stebalien on 29 Mar 2018
👍4

>All comments

More: Make it actually work like ssh -L. It should forward every connection, not just the first. See https://github.com/ipfs/go-ipfs/pull/4894#issuecomment-377287053.

Stebalien picture Stebalien on 29 Mar 2018
👍4
Was this page helpful?
0 / 5 - 0 ratings

Related issues

magik6k picture magik6k  路  3Comments
whyrusleeping picture whyrusleeping  路  4Comments
whyrusleeping picture whyrusleeping  路  4Comments
magik6k picture magik6k  路  3Comments
funkyfuture picture funkyfuture  路  3Comments