Go-github: Remove mediaTypeRequiredApprovingReviewsPreview header from remaining APIs

[n1lesh]

As mentioned in,
https://developer.github.com/changes/2018-03-16-protected-branches-required-approving-reviews/

only 4 endpoints require mediaTypeRequiredApprovingReviewsPreview header as mentioned in here as well.

Can we remove the header in remaining APIs, namely status checks APIs, as I see it being used in around 14 endpoints, or am I missing something?

[gmlewis]

Hmmm... I think we have a disconnect. If I search for that custom media header in this repo, I see this:

https://github.com/google/go-github/search?q=mediaTypeRequiredApprovingReviewsPreview

which shows it being used in two locations:

• https://github.com/google/go-github/blob/c2c4a6d477016a3e73a63d67b1933fb24f52fd99/github/repos.go#L924
• https://github.com/google/go-github/blob/c2c4a6d477016a3e73a63d67b1933fb24f52fd99/github/repos.go#L946

These appear to have been modified most recently in: https://github.com/google/go-github/pull/880

Can you please clarify where you are seeing this custom media header?

[n1lesh]

Well, I took the latest for the last pull request, plus here, https://github.com/google/go-github/blob/c2c4a6d477016a3e73a63d67b1933fb24f52fd99/github/repos.go, where I can see it being used multiple times.

I guess here they are just showing the top 2 matches, but if you open the file, it's more than 2.

[gmlewis]

Ah! You are right! Mine was the disconnect. Sorry about that.

Then yes, please feel free to submit a PR to clean these all up, or we can open it up to another volunteer to do this... your choice.

Thank you, @n1lesh !

[n1lesh]

Will work on it, no problem. Thank you, @gmlewis