Go-github: I think the condition "resp.ContentLength == -1" isn't needed because "-1" < "2048"

Created on 10 Sep 2020  路  3Comments  路  Source: google/go-github

https://github.com/google/go-github/blob/master/github/github.go#L576

picture Sympho

All 3 comments

Yes, that is true, and we have an open PR addressing that issue: https://github.com/google/go-github/pull/1615/files

gmlewis picture gmlewis on 11 Sep 2020
👍1

@gmlewis I think this issue can be closed now, code in question has been removed : https://github.com/google/go-github/commit/c5b0f2133dafff1990647022a89886d173e3d7e6

chughpiyush picture chughpiyush on 6 Dec 2020
👍1

Good call, @chughpiyush .
Closing issue as obsolete.

gmlewis picture gmlewis on 6 Dec 2020
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

you06 picture you06  路  3Comments
scriptonist picture scriptonist  路  3Comments
gmlewis picture gmlewis  路  3Comments
OGKevin picture OGKevin  路  3Comments
gmlewis picture gmlewis  路  3Comments