Go-github: Remove some fields of IssueListCommentsOptions

Created on 22 Jul 2020  路  5Comments  路  Source: google/go-github

Most helpful comment

I can work on this! 馃榿

All 5 comments

Thank you, @you06 !
The Sort and Direction fields need to be removed. Although these apparently no longer are supported, this change is still a breaking API change, so I will mark it that way.

This would be a great PR for any new contributor to this repo or a new Go developer.
All contributions are greatly appreciated!

Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.

Please check out our CONTRIBUTING.md guide to get started.

Thank you!

I can work on this! 馃榿

Thank you, @juanri0s ! It is yours.

@gmlewis I have removed the fields from the struct and the fields in the tests as well. Are we expecting this change in any other area other than issues_comments.go? Or do I need to go through the GH API docs and check myself?

These fields were identified in the issue. You are welcome to look through the docs for other discrepancies.

Was this page helpful?
0 / 5 - 0 ratings