Go-github: Add unit tests for URL escaping for ref parameters

Created on 19 Jan 2019  路  7Comments  路  Source: google/go-github

This issue is so that we don't lose track of @gauntface's comment about adding unit tests to #1099.

enhancement good first issue

Most helpful comment

@gmlewis I want to take this issue. Please assign to me

All 7 comments

@gmlewis I want to take this issue. Please assign to me

I can't assign the issue to you, @vaibhavsingh97 but consider it yours.
Thank you!

Thanks, will send PR for same 馃

Hi @vaibhavsingh97 , are you working on this?

@Avni-Sharma yes, sorry for the delay was a busy week, will send PR shortly

@gmlewis I am stuck here for long time, please help me with this
I wrote the unit test but I don't know how to test it. I read how to contribute file aka contributing.md, but when I forked the repository and run go build ./... and go test ./... and it failed to find packages but when I clone go-github and run same commands then I am able to build and compile
image

It looks like you are missing dependencies needed by this package. You should be able to run go get -u github.com/google/go-github and it will get all the needed dependencies. Alternatively, you can run go get -u on each package that is missing, but that shouldn't be necessary.

Was this page helpful?
0 / 5 - 0 ratings