Go-github: github-accessors.go: Missing accessors for non-Struct type fields

[sahildua2305]

While working on #770, I noticed that we are creating accessors only for fields which have a struct type. I looked further into it today and confirmed the same. Is this intentional? If so, why?
/cc @gmlewis @shurcooL

[gmlewis]

I'm not sure I understand what you mean.
https://github.com/google/go-github/blob/master/github/github-accessors.go#L24
returns a string, for example.

[dmitshur]

@sahildua2305 Can you give some examples of fields that are missing accessors?

[sahildua2305]

For example - https://github.com/google/go-github/blob/8c08f4fba5e05e0fd2821a5f80cf0cf643bd5314/github/activity.go#L30
here - CurrentUserOrganizationURLs won't have any accessor because of the following logic -
https://github.com/google/go-github/blob/8c08f4fba5e05e0fd2821a5f80cf0cf643bd5314/github/gen-accessors.go#L103

[dmitshur]

The type of that particular field CurrentUserOrganizationURLs is []string. It’s not a pointer.

Not having an accessor for it seems reasonable, since the accessors exist for pointer fields to help prevent nil pointer dereference panics when a field is missing. Since there’s no pointer here, there’s nothing to protect against. The following code can never panic:

fmt.Println(len(feeds.CurrentUserOrganizationURLs))

Does that make sense? Or am I missing something? What would having an accessor for that field accomplish?

[sahildua2305]

Oh right! Makes sense. I knew I was missing something. Thanks for clearing it out. 💯