Go-github: Support new Webhooks for Projects

[gmlewis]

Announcement:
https://developer.github.com/changes/2017-01-24-project-webhooks/

[varadarajana]

@gmlewis I would like to work on this issue. Can you please assign this to me?

[gmlewis]

Done. Thank you, @varadarajana!

[sahildua2305]

@varadarajana how's it going with this one?

[dmitshur]

There's an open PR #530 that mentions it.

[sahildua2305]

@shurcooL oh yes, alright!

@varadarajana it's always good to mention the issue you're trying to resolve in the PR so that others also know that there is/was a PR for this issue and may get to know the history of an issue. :smile:

[varadarajana]

Sure @sahildua2305, I have changed it now.

[dmitshur]

This issue was resolved via PR #544, which was recently merged, so closing.

Note, it wasn't closed automatically because neither the PR description, nor the commit message of 2694dcaaa60686a8c69d923b3d365fb9375d7e9a said "Closes #530." or equivalent. I also mentioned this in https://github.com/google/go-github/pull/544#issuecomment-279529942. /cc @varadarajana @gmlewis FYI.

[gmlewis]

Ah, so that is the case where I would need to add to the commit message during "Squash and merge" then. Thanks, @shurcooL.

[dmitshur]

Yep, at least one of the PR description or commit message needs to mention that it resolves an issue, otherwise GitHub has no way of knowing what issue(s), if any, to automatically close.

References:

• https://help.github.com/articles/closing-issues-via-commit-messages/
• https://github.com/blog/1506-closing-issues-via-pull-requests

Note that Pull Request title does not count, it has to be in the body, and it has to match the expected syntax exactly:

All you have to do is include the special keyword syntax (eg. fixes #5) in the body of your Pull Request.