Go-ethereum: Change "blacklist" to "list of color"

[verretor]

There are 86 occurrences of "blacklist" in this repository. I suggest changing those to "list of color".

signer/fourbyte/4byte.json:134841:"eb464316": "TOKENSALE_BLACKLIST()",
signer/fourbyte/4byte.go:134890:"eb464316": "TOKENSALE_BLACKLIST()",
cmd/puppeth/module_ethstats.go:161: // Retrieve the IP blacklist
cmd/puppeth/wizard_ethstats.go:66:  // Gather any blacklists to ban from reporting
cmd/puppeth/wizard_ethstats.go:69:      fmt.Printf("Keep existing IP %v blacklist (y/n)? (default = yes)\n", infos.banned)
cmd/puppeth/wizard_ethstats.go:73:          fmt.Printf("Clear out blacklist and start over (y/n)? (default = no)\n")
cmd/puppeth/wizard_ethstats.go:79:          fmt.Println("Which additional IP addresses should be blacklisted?")
cmd/puppeth/wizard_ethstats.go:88:          fmt.Println("Which IP addresses should not be blacklisted?")
signer/fourbyte/4byte.json:2407:"041f173f": "blacklist(address[])",
signer/fourbyte/4byte.json:13178:"16f573e6": "addtoblacklist(address)",
signer/fourbyte/4byte.json:15801:"1b848606": "blacklistEscapeToken(address)",
signer/fourbyte/4byte.json:21786:"260d387b": "blacklistUserForTransfers(address)",
signer/fourbyte/4byte.json:25806:"2cfc42f5": "blacklistParty(address,address,bool)",
signer/fourbyte/4byte.json:26031:"2d5a5d34": "blacklistAccount(address,bool)",
signer/fourbyte/4byte.json:45353:"4f0a746f": "blacklistAddress(address,address)",
signer/fourbyte/4byte.json:49019:"55642e53": "blacklist(bytes32)",
signer/fourbyte/4byte.json:52548:"5bae9ce9": "blacklisted()",
signer/fourbyte/4byte.json:67600:"75e3661e": "unblacklist(address)",
signer/fourbyte/4byte.json:68597:"77a54eb8": "blacklistAddresses(address[])",
signer/fourbyte/4byte.json:75004:"83111397": "blacklistAddr(address[])",
signer/fourbyte/4byte.json:78957:"8a294c60": "blacklisting(address)",
signer/fourbyte/4byte.json:81407:"8e77fe2f": "blacklistAddresses(address)",
signer/fourbyte/4byte.json:93618:"a3a402a7": "deletefromblacklist(address)",
signer/fourbyte/4byte.json:94222:"a4b5fa56": "blacklist()",
signer/fourbyte/4byte.json:99059:"ad28ff88": "blacklist(address,address)",
signer/fourbyte/4byte.json:108212:"bd102430": "blacklister()",
signer/fourbyte/4byte.json:109885:"bfebb947": "unblacklist(bytes32)",
signer/fourbyte/4byte.json:121175:"d37b34d7": "blacklistAccount(address)",
signer/fourbyte/4byte.json:123791:"d81494ba": "blacklist_addys(address[])",
signer/fourbyte/4byte.json:138587:"f1b07f96": "deblacklistAddress(address,address)",
signer/fourbyte/4byte.json:142120:"f7decfd1": "blacklistSwitch()",
signer/fourbyte/4byte.json:143362:"f9f92be4": "blacklist(address)",
signer/fourbyte/4byte.json:146710:"ffc1b038": "blacklistInvestor(address)",
signer/fourbyte/4byte.go:2456:"041f173f": "blacklist(address[])",
signer/fourbyte/4byte.go:13227:"16f573e6": "addtoblacklist(address)",
signer/fourbyte/4byte.go:15850:"1b848606": "blacklistEscapeToken(address)",
signer/fourbyte/4byte.go:21835:"260d387b": "blacklistUserForTransfers(address)",
signer/fourbyte/4byte.go:25855:"2cfc42f5": "blacklistParty(address,address,bool)",
signer/fourbyte/4byte.go:26080:"2d5a5d34": "blacklistAccount(address,bool)",
signer/fourbyte/4byte.go:45402:"4f0a746f": "blacklistAddress(address,address)",
signer/fourbyte/4byte.go:49068:"55642e53": "blacklist(bytes32)",
signer/fourbyte/4byte.go:52597:"5bae9ce9": "blacklisted()",
signer/fourbyte/4byte.go:67649:"75e3661e": "unblacklist(address)",
signer/fourbyte/4byte.go:68646:"77a54eb8": "blacklistAddresses(address[])",
signer/fourbyte/4byte.go:75053:"83111397": "blacklistAddr(address[])",
signer/fourbyte/4byte.go:79006:"8a294c60": "blacklisting(address)",
signer/fourbyte/4byte.go:81456:"8e77fe2f": "blacklistAddresses(address)",
signer/fourbyte/4byte.go:93667:"a3a402a7": "deletefromblacklist(address)",
signer/fourbyte/4byte.go:94271:"a4b5fa56": "blacklist()",
signer/fourbyte/4byte.go:99108:"ad28ff88": "blacklist(address,address)",
signer/fourbyte/4byte.go:108261:"bd102430": "blacklister()",
signer/fourbyte/4byte.go:109934:"bfebb947": "unblacklist(bytes32)",
signer/fourbyte/4byte.go:121224:"d37b34d7": "blacklistAccount(address)",
signer/fourbyte/4byte.go:123840:"d81494ba": "blacklist_addys(address[])",
signer/fourbyte/4byte.go:138636:"f1b07f96": "deblacklistAddress(address,address)",
signer/fourbyte/4byte.go:142169:"f7decfd1": "blacklistSwitch()",
signer/fourbyte/4byte.go:143411:"f9f92be4": "blacklist(address)",
signer/fourbyte/4byte.go:146759:"ffc1b038": "blacklistInvestor(address)",
core/error.go:25:   // ErrBlacklistedHash is returned if a block to import is on the blacklist.
core/error.go:26:   ErrBlacklistedHash = errors.New("blacklisted hash")
signer/fourbyte/4byte.json:2979:"0522345a": "blackListFreezeTime()",
signer/fourbyte/4byte.json:3439:"05ff711b": "blackList(uint32)",
signer/fourbyte/4byte.json:16698:"1d231b2c": "_blackListed(address)",
signer/fourbyte/4byte.json:30012:"3470b833": "blackListERC223(address)",
signer/fourbyte/4byte.json:41375:"4838d165": "blackList(address)",
signer/fourbyte/4byte.json:46443:"50ec5903": "blackListSwithcer(address)",
signer/fourbyte/4byte.json:91693:"a057dade": "blackListUser(address,address)",
signer/fourbyte/4byte.json:91950:"a0c567a2": "blackListActive()",
signer/fourbyte/4byte.json:99104:"ad37c41b": "blackListEnabled()",
signer/fourbyte/4byte.json:112173:"c3e58eec": "blackListSectorExists(uint8[])",
signer/fourbyte/4byte.json:114060:"c71c3f05": "blackListCompanies()",
signer/fourbyte/4byte.json:117839:"cdab73b5": "blackList()",
signer/fourbyte/4byte.json:120644:"d288c878": "blackListERC20(address)",
signer/fourbyte/4byte.go:3028:"0522345a": "blackListFreezeTime()",
signer/fourbyte/4byte.go:3488:"05ff711b": "blackList(uint32)",
signer/fourbyte/4byte.go:16747:"1d231b2c": "_blackListed(address)",
signer/fourbyte/4byte.go:30061:"3470b833": "blackListERC223(address)",
signer/fourbyte/4byte.go:41424:"4838d165": "blackList(address)",
signer/fourbyte/4byte.go:46492:"50ec5903": "blackListSwithcer(address)",
signer/fourbyte/4byte.go:91742:"a057dade": "blackListUser(address,address)",
signer/fourbyte/4byte.go:91999:"a0c567a2": "blackListActive()",
signer/fourbyte/4byte.go:99153:"ad37c41b": "blackListEnabled()",
signer/fourbyte/4byte.go:112222:"c3e58eec": "blackListSectorExists(uint8[])",
signer/fourbyte/4byte.go:114109:"c71c3f05": "blackListCompanies()",
signer/fourbyte/4byte.go:117888:"cdab73b5": "blackList()",
signer/fourbyte/4byte.go:120693:"d288c878": "blackListERC20(address)",

[dx-dt]

ACK Block Lists Matters.

[holiman]

Well, for all instances of signer/fourbyte/4byte.json:2979:"0522345a": "blackListFreezeTime()", -- those are 'preimages' of smart contract signatures, not our code

[verretor]

Well, for all instances of signer/fourbyte/4byte.json:2979:"0522345a": "blackListFreezeTime()", -- those are 'preimages' of smart contract signatures, not our code

That leaves those instances:

cmd/puppeth/module_ethstats.go:161: // Retrieve the IP blacklist
cmd/puppeth/wizard_ethstats.go:66:  // Gather any blacklists to ban from reporting
cmd/puppeth/wizard_ethstats.go:69:      fmt.Printf("Keep existing IP %v blacklist (y/n)? (default = yes)\n", infos.banned)
cmd/puppeth/wizard_ethstats.go:73:          fmt.Printf("Clear out blacklist and start over (y/n)? (default = no)\n")
cmd/puppeth/wizard_ethstats.go:79:          fmt.Println("Which additional IP addresses should be blacklisted?")
cmd/puppeth/wizard_ethstats.go:88:          fmt.Println("Which IP addresses should not be blacklisted?")
core/error.go:25:   // ErrBlacklistedHash is returned if a block to import is on the blacklist.
core/error.go:26:   ErrBlacklistedHash = errors.New("blacklisted hash")

[jnewbery]

Maintainers: this user has a history of abusing open source repos: https://github.com/bitcoin/bitcoin/pull/19897. I've already reported to GitHub for abuse of github community guidelines.

[verretor]

Maintainers: this user has a history of abusing open source repos: bitcoin/bitcoin#19897. I've already reported to GitHub for abuse of github community guidelines.

It was merged though and we agreed to a better name.

[rockstardev]

To maintainers: @jnewbery has a history of dominating open source repositories with this political views and coordinating - disregard his post. @verretor please reference my post in any response to GitHub, if needed I'll gladly vouch that you are not abuser.

[verretor]

To maintainers: @jnewbery has a history of dominating open source repositories with this political views and coordinating - disregard his post. @verretor please reference my post in any response to GitHub, if needed I'll gladly vouch that you are not abuser.

Thank you.

Now, about this specific issue, I think we could have a discussion. For instance, "blacklist" could be changed to "denylist". This is just a suggestion.

[prayank23]

Maintainers: this user has a history of abusing open source repos: bitcoin/bitcoin#19897. I've already reported to GitHub for abuse of github community guidelines.

@jnewbery the PR you mentioned was not abuse in anyway

It highlights some important issues and should not be ignored.

1. Variable change PR merged too soon. Was unnecessary change. "blocklist" didn't make sense.

2. If PR to revert or change variable name to something better is created, devs working on core from a long time should not have issues with it. You may disagree with the PR and give NACK which is different from reporting someone for abuse.

3. TrentZ was random person trying to change a variable name. In future, there can be better ways to try and change things with social engineering involved.

[karalabe]

Thank you for the suggestion. We'll consider it and make any changes the team decides to go with (which may be none), whenever it does so. I've closed and locked this issue as I'd like to avoid a PC battleground here. We'll definitely keep in mind and try to avoid sensitive wordings in future code.