Go-ethereum: Document `trusted-nodes.json` or remove it

[paulvi]

Where is documentation about trusted-nodes.json ? ref #14472

• [ ] Commits like 62fc96620d864291dc56bae5568cbaa44714c19f should go with documentation updates.

Both resources below do not mention about trusted-nodes:

• https://github.com/ethereum/homestead-guide/blob/master/source/network/connecting-to-the-network.rst#static-nodes-trusted-nodes-and-boot-nodes
• https://github.com/ethereum/go-ethereum/wiki/Connecting-to-the-network

[RichHorrocks]

From here:

    // Trusted nodes are used as pre-configured connections which are always
    // allowed to connect, even above the peer limit.
    TrustedNodes []*discover.Node

There are various questions about Trusted Nodes on Stack Exchange (example, another example).

[paulvi]

Thank you Richard.

No it is clear, that this is undocumented feature, that one needs to read code

https://github.com/ethereum/go-ethereum/blob/5490437942967638bcc6198035315f6811febaa8/p2p/server.go#L91-L93

What is place for geth Documentation ?

http://ethdocs.org/en/latest/network/connecting-to-the-network.html#static-nodes-trusted-nodes-and-boot-nodes currently does not have notion about trusted-nodes.json
(but it had so as said in https://ethereum.stackexchange.com/questions/2478/what-is-the-difference-between-a-static-node-and-a-trusted-node)

BTW, command line help should references this feature (otherwise simple math will not work for unaware users)

NETWORKING OPTIONS:
...
  --maxpeers value      Maximum number of network peers (network disabled if set to 0) (default: 25)

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[MysticRyuujin]

I think this should get a bump

[adamschmideg]

We may not need this feature anymore. We're going to ask around if users rely on trusted nodes.

[MysticRyuujin]

I'm just one guy and I may or may not be using it correctly, but I assign my local nodes to each other. Especially during a re-sync, in the hopes that my nodes are used for the majority of the bandwidth vs going over the internet. When I have SSD 10Gb nodes sitting on the same LAN I'd prefer them to sync from each other initially and during catch up periods (downtime).