Gnome-shell-system-monitor-applet: Unit texts are not aligned correctly after numerical values.

[Ecron]

When clicking over the widget, the units shown after the numbers are not correctly aligned after the numerical values, as shown in the picture below (texts in Catalan):

I guess the final result should be something like the following mockup:

In this mockup, I also aligned the single-valued parameters to the first left column.

Is there any way to fix this layout?

[franglais125]

Hey, thanks for opening this. So I fixed this in the link [1], but not exactly in the same way you are proposing. You can see what I modified and it will give you an idea on how to change it yourself, as there is more than one way to arrange the spaces.

Anyway, from your screenshot and mine, I am not sure it looks much better, it looks a bit crowded. I won't open a PR for this. Instead I'll wait for more feedback. As I said, I'm not sure it looks better.

Thoughts anyone?

[1] https://github.com/franglais125/gnome-shell-system-monitor-applet/tree/align_units

[Ecron]

In my opinion, that's a nice improvement, that's basically what I was asking for. I don't feel it more crowded, but more understandable, now every unit is next to its numerical value :+1:

In my mockup I aligned single-valued parameters to the first column, but that's just because I didn't understand why there's so much blank space between, for example, CPU and 7%, or Thermal and 49ºC.

EDIT: I tweaked a little the extension.js file and I created a version that totally matches my mockup. Here. I can make a PR as soon as someone tells me to :wink:

[DevDef]

Definitely better!

[franglais125]

@Ecron do you mind posting a screenshot of the result with your patch?

[Ecron]

Here it is:

Do you want me to create a PR?

[franglais125]

Sure! It looks better in my opinion.

Moltes gracies!

[franglais125]

@ecron (and everyone), what do you think o this mockup?

I added the percentage value for Memory and Swap, hence it looks more harmonised.

You can find it here: https://github.com/franglais125/gnome-shell-system-monitor-applet/tree/align_units, including your patch.

[DevDef]

That’s even better. :-)

[Ecron]

@franglais125 Yep, that's an even better implementation. It both gives extra and useful info and makes the UI cleaner. +1 for your addition :+1:

Could you tell us when the update with this new addition hits the Extensions site? I didn't wanted to update because I would lose my modification, but with yours, I can update freely 😄

[franglais125]

Sounds good! Thanks for the feedback @Ecron and @DevDef , I'll include this in the other PR I have opened. Cheers!

[franglais125]

This was fixed in https://github.com/paradoxxxzero/gnome-shell-system-monitor-applet/pull/375.

Thanks again for your input :).

[Ecron]

You're very welcome :wink: