Glow: [New operator] FCTransposed

Created on 24 Sep 2018  路  5Comments  路  Source: pytorch/glow

We need to support FCTransposed operator from Caffe2. Spec can be found here:
https://caffe2.ai/docs/operators-catalogue.html#fctransposed

help wanted

Most helpful comment

Yes, for this operator, one needs to change only Caffe2.cpp and add test.
No need to have createFCTransposed in the Graph class.
Create transpose for weights, create regular FC. Perhaps reuse existing code for FC to avoid duplication:
https://github.com/pytorch/glow/blob/72c28e22e31091db455c1cec5fbcf734a615c646/lib/Importer/Caffe2.cpp#L296

All 5 comments

Just to double check. When we say new operator that means adding this operator in the loader, not necessarily adding a new glow node, right?
In particular for this case, the loader would have to emit (FC input, (transpose W)).

I think adding this kind of details for the various issues you've added (thanks BTW) would help potential contributors to jump in. Otherwise we may scare them away :).

Yes, for this operator, one needs to change only Caffe2.cpp and add test.
No need to have createFCTransposed in the Graph class.
Create transpose for weights, create regular FC. Perhaps reuse existing code for FC to avoid duplication:
https://github.com/pytorch/glow/blob/72c28e22e31091db455c1cec5fbcf734a615c646/lib/Importer/Caffe2.cpp#L296

馃Nice 馃

Going to add this operator for ONNX/ONNXIFI support.

closing this as the change was merged.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

pjaaskel picture pjaaskel  路  4Comments

artemrakhov-glow picture artemrakhov-glow  路  4Comments

jackm321 picture jackm321  路  3Comments

tkclimb picture tkclimb  路  4Comments

tlepley-cadence picture tlepley-cadence  路  4Comments