Glide: `glide get <pkg>` should not update other dependencies in the glide.yaml/lock files

Created on 2 Jun 2017 · 6Comments · Source: Masterminds/glide

This came up in this pull request: https://github.com/Azure/acs-engine/pull/716

It seems that glide get <pkg> is causing other packages to experience a glide up effectively.

Is this expected? It seems undesirable. Possibly related to https://github.com/Masterminds/glide/issues/252?

Source

colemickens

👍5

Most helpful comment

yeah, this is really annoying bug :/

rusenask on 1 Jul 2017

👍3

All 6 comments

yeah, this is really annoying bug :/

rusenask on 1 Jul 2017

👍3

+1 on the annoying'ness.

taherv on 3 Jul 2017

👍2

If it matters, this comment talks about exactly the same "streamlining" that this bug needs ...
In pkg/action/get.go: func Get()

if !skipRecursive {
                  // Get all repos and update them.
                  // TODO: Can we streamline this in any way? The reason that we update all
                 // of the dependencies is that we need to re-negotiate versions. For example,
                 // if an existing dependency has the constraint >1.0 and this new package
                  // adds the constraint <2.0, then this may re-resolve the existing dependency
                  // to be between 1.0 and 2.0. But changing that dependency may then result
                  // in that dependency's dependencies changing... so we sorta do the whole
                 // thing to be safe.
                  err = installer.Update(confcopy)
                  if err != nil {
                                 msg.Die("Could not update packages: %s", err)
                  }
   }

Shouldn't the addpkgstoconfig method return some metadata to see if a global update is required ? That could be one way to fix this bug.

taherv on 7 Jul 2017

👍1

Is this a duplicate of #328 ?