The ProGuard configuration in the README is insufficient when using DexGuard, the commercial version of ProGuard. It requires one more directive for an app to work correctly:
-keepresourcexmlelements manifest/application/meta-data@value=GlideModule
I figure you might want to add this to the wiki and/or the primary documentation.
Glide Version: 3.7.0
barend
All 17 comments
Do you think it's sufficient to do this on master (v4), or you're reading the 3.0 branch's readme?
TWiStErRob
on 12 Jul 2016
It's not tied to any particular version of Glide. DexGuard obfuscates the contents of the meta-data element in the Android Manifest, and this causes the "Unknown Type Class" IllegalArg to be thrown.
To be honest it's pretty niche. I suppose anywhere Google can find it is good enough.
barend
on 12 Jul 2016
I asked because I was interested in which README.md you did read.
I added it to the wiki: https://github.com/bumptech/glide/wiki/Configuration#keeping-a-glidemodule
and noted down to update the README as well.
I suppose anywhere Google can find it is good enough.
That's already done by you... this issue ;)
TWiStErRob
on 12 Jul 2016
Just curious: what is the rationale behind DexGuard removing metadata from the manifest? Is skimming off those 100 bytes from the compiled XML worth it?
TWiStErRob
on 12 Jul 2016
It's not about size, it's about obfuscation. Removing/scrambling as much information as possible to make the app harder (or at least more irritating) to reverse engineer. This includes assets and resources.
barend
on 12 Jul 2016
I'm getting Error:Execution failed for task ':app:transformClassesAndResourcesWithProguardForRelease'.
java.io.IOException: proguard.ParseException: Unknown option '-keepresourcexmlelements' in line 317 of file '...../app/proguard-rules.pro'
Android Studio 2.2 Beta 3
Build #AI-145.3225885, built on August 26, 2016
JRE: 1.8.0_76-release-b03 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Gradle Plugin 2.1.3
Gradle 2.14.1
ernestp
on 31 Aug 2016
@ernestp It says "for DexGuard only", just remove the line if you use ProGuard.
TWiStErRob
on 31 Aug 2016
@TWiStErRob main page says ProGuard but ProGuard throws with -keepresourcexmlelements - should be mentioned imho
black-snow
on 12 Jan 2017
@black-snow #1666 fixes this
TWiStErRob
on 12 Jan 2017
@TWiStErRob great!
black-snow
on 13 Jan 2017
I'm going to close this, if there's more changes needed feel free to make PR against master/README.md or comment to request Wiki updates.
TWiStErRob
on 13 Jan 2017
In my case, I found this error when create release apk.
- App module have lib module.
- Lib module have Glide and use Dexguard -keepresourcexmlelements manifest/application/meta-data@value=GlideModule.
- App module use Proguard.
How can i fixed it?
oatpano
on 17 Jan 2018
-keep class okhttp3.internal.publicsuffix.PublicSuffixDatabase
Doesn't helped to fix the issue for me... I have the same issue as mentioned by @oatpano
helloukey
on 10 Dec 2018
Unknown option '-keepresourcexmlelements'
KishanViramgama
on 5 Mar 2019
@KishanViramgama https://github.com/bumptech/glide/issues/1331#issuecomment-243657947?
TWiStErRob
on 5 Mar 2019
Why this issue is closed?
squm
on 12 Dec 2019
@squm why do you think it shouldn't be closed?
TWiStErRob
on 12 Dec 2019
Related issues
mttmllns
路
3Comments
sergeyfitis
路
3Comments
ersen-osman
路
3Comments
FooBarBacon
路
3Comments
Morteza-Rastgoo
路
3Comments
Most helpful comment
@ernestp It says "for DexGuard only", just remove the line if you use ProGuard.