Givewp: chore: add php 7.2 and 7.3 support for unit test with travis

[mehul0810]

Feature Request

User Story

As a user, I want to see Give works properly with PHP 7.2 and 7.3 so that there are no errors.

Note: We can work on this issue in mid-December this year as PHP 7.3 is scheduled to release in December 2018, so that we can add support for both PHP versions at the same time without wasting any additional time.

Visuals

PHP Versions supported with Travis currently

Acceptance Criteria

• [x] Drop PHP 5.3 test.
• [x] Add PHP 7.2 support to Travis with and without multisite
• [x] Add PHP 7.3 support to Travis with and without multisite

[DevinWalker]

I added 7.2 and 7.3 testing but now we're running into some PHPunit compatibility issues:

PHPUnit compatibility page: https://phpunit.de/supported-versions.html

[DevinWalker]

I did some research and it looks like this is a WP Core PHPUnit testing issue that is set to be resolve in release 5.1: https://core.trac.wordpress.org/ticket/43218

I'm going to remove the code to test PHP 7.2 and 7.3 in place for now unit WP Core 5.1 version is released: https://core.trac.wordpress.org/query?status=reopened&status=assigned&status=reviewing&status=new&status=accepted&group=status&milestone=5.1

[koconder]

@DevinWalker have a look at my repo: https://github.com/koconder/wordpress-test-template and a plugin you can see the Travis CI setup on: https://github.com/koconder/wordpress-test-template

Shout if you need me to jump in and build out a PR for your issue or help test your Travis CI configuration.

[koconder]

It's https://github.com/impress-org/give/blob/release/2.4.1/tests/bin/install.sh that is majorly outdated, I have in the test plugin a reference to the main repo where I maintain the Travis CI setup and .sh install scripts.

[DevinWalker]

Now that WP supports PHPUnit 7.x we now have a new release of PHPUnit 8.x which WP does not support. This results in the following issue now with my recent changes:

[koconder]

@DevinWalker as per my last messages. You can see an example here from my boilerplate repo https://github.com/koconder/wordpress-test-template

Test results: https://travis-ci.org/koconder/wordpress-test-template/builds/547591604
Working across all key PHP versions with PHP 7.x, with PHPUnit tests across WP 5.0, 5.1, and 5.2 on low and high PHP versions. Btw WP latest can fail as the development branch is not always passing tests.

@DevinWalker @mehul0810 @kevinwhoffman - I'm happy to jump in and resolve

[DevinWalker]

@koconder that looks passing for sure. I wasn't able to achieve that but it's been a few months since I tried. If you would like to contribute towards getting this issue resolved we'd love to have a PR! Thanks for the follow up.

[koconder]

@DevinWalker i'll give it a go for you guys!

[mikejhale]

@koconder If you're still interested in giving another look at this one it would be appreciated.