Givewp: Fix non-donation / ecommerce terminology in actions and filters

[DevinWalker]

There are many actions and filters throughout the plugin which use ecommmerce terminology such as give_purchase_form, give_purchase_form_wrap_bottom, give_purchase_form_before_submit, etc.

We should deprecate them and replace with donation based terminology. give_purchase_form --> give_donation_form, give_purchase_form_wrap_bottom -> give_donation_form_wrap_bottom

Task list:

• [x] Rename directories
• [ ] Rename variables
• [ ] Rename hooks (actions + filters)
• [x] Rename classes
• [x] Rename db tables w/ upgrade routine

All items above with backwards compatibility

[ramiy]

Agree, we need to consolidate Give terminology.

Here is another example for three different names for the same thing:

I think we need to fix the front-end first, and only then the classes/functions/hooks names.

[ramiy]

As for the purchase, it is deeply embedded in the code. We have function names using this word, class properties and methods, and maybe even options (not sure about the last one - I need to check that).

It's a backwards-compatibility nightmare.

[DevinWalker]

Yeah I know, that's why I've been resisting it. This is an ongoing gradual task.

[DevinWalker]

Link for reference to _deprecated_hook function new to WP 4.6

Changeset: https://core.trac.wordpress.org/changeset/37861

Ticket: https://core.trac.wordpress.org/ticket/10441

[ramiy]

@DevinWalker Translations strings updates are simpler and faster. I can do it in 1.7 , I just need know which word is preferred?

[DevinWalker]

"Transactions" -> "Donations"

"Payment" -> "Donation"

@mathetos thoughts?

[ramiy]

@DevinWalker @mathetos

One more terminology suggestion: Donators > Donors

Ref: https://github.com/WordImpress/Give/blob/master/includes/class-give-gravatars.php

Do you agree?

[DevinWalker]

@ramiy yes definitely, that class isn't being used yet though :(

[ravinderk]

@DevinWalker Can you suggest what will be name of this action hook.
give_checkout_form_top

because will already have give_purchase_form_top --> give_donation_form_top
https://github.com/WordImpress/Give/blob/release/1.7/includes/deprecated/deprecated-actions.php#L42

[DevinWalker]

I've been thinking about the usage of the word payment and I think it's applicable and relevant to our plugin in certain circumstances. For example, give_payment_gateways should remain as such and NOT change to give_donation_gateways. Reasoning being a donation is still a _payment_. From a development perspective it is less confusing to continue referring it as a payment.

I will update with this comment a complete like of hooks where the work payment is permitted.

[ramiy]

I'm not sure I agree. You can argue that when you are talking about gateways, you are talking only about payment gateways, there is no other type of gateway.

So, we can change give_payment_gateways to give_gateways.

[DevinWalker]

This bulk of this task is done. As we continue to refactor we can take care of the remaining hooks and variables.