Giveth-dapp: Stuck milestones

[Joshfairhead]

So I hit disperse on these a little while back (at least a week) and when checking in on progress I found this screen which seems to be a failure of some sort:

After some investigation a note is that it's potentially due to the first milestone which has received mixed currency donations. After that its singular currency donations but they are also stuck. https://app.zenhub.com/files/98920496/79a0cea9-ad8f-447d-90d9-1d39dd853167/download

Milestone one (mixed currency): https://beta.giveth.io/campaigns/5b37e5caa239ac21b383d4dd/milestones/5cd059162f70601995ce89c9

Reward DAO milestone March: https://beta.giveth.io/campaigns/5b3d9746329bc64ae74d1424/milestones/5cc5ef48cf48770f67ee86b4

Reward DAO milestone April: https://beta.giveth.io/campaigns/5b3d9746329bc64ae74d1424/milestones/5ccc9addcf48770f67ee8727

[arbreton]

Reviewing the donations on this milestones they successfully made it to the bridge but they don't appear on the bridge according to @bowensanders, what would be the next steps on this? @ewingrj , @mroberts10

[bowensanders]

Is it possibly related to the fact that in this example there is no recipient address??

[bowensanders]

That was from THIS milestone: https://beta.giveth.io/campaigns/5b3d9746329bc64ae74d1424/milestones/5cc5ef48cf48770f67ee86b4
Also the other two milestones did not have a recipient address. Chances are this isn't even a bug, but that the address was not added when the milestones were created. That's my guess - Unless there's an issue with adding a recipient address after completion, adding the address should make them pushable, right?

[Joshfairhead]

Damn, quite possibly some idiocy my end there (tho I feel like I filled
that in) but the problem remains due to an AWOL edit button... (i.e. non
existent)!

[bowensanders]

I believe that it is missing because you are not the reviewer and or the milestone has been accepted as complete

---- On Fri, 14 Jun 2019 16:49:56 -0700 [email protected] wrote ----

Damn, quite possibly some idiocy my end there (tho I feel like I filled
that in) but the problem remains due to an AWOL edit button... (i.e. non
existent)!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[arbreton]

I think i can apply a quick fix temporarily for the funds to go through, also when the funds are still not paid the milestone should not go to completed, i will need to check on that seems to be a UI problem

[arbreton]

@Joshfairhead, Everything should be ok now Josh, please set recipient address before marking complete everything should be good to go.

I'm also uploading a fix which would prevent users to mark complete without setting a recipient address first.

[Joshfairhead]

Cheers Andre, unfortunately its still not working for me!

The UI has reverted to normal, however clicking edit throws the error
screen which stops me from editing the recipient address.

This is the address I'd use FYI :)
0xf89AD13EfF9d9d1cd5768dFf658C68A8108D38C5

Cheers!
ᐧ

[Joshfairhead]

However I did find the big green "set recipient" button which allowed me to
input the address.

Clicking "Mark complete" however throws an error now instead. It pops up
the window asking for a note, I add the note but then it fails. I have
tried this from "My Milestones" and from the milestone directly in several
ways.
ᐧ

[arbreton]

@Joshfairhead you should be able to collect now on your milestones tab, please confirm thank you! have a nice weekend

[Joshfairhead]

---

Mobile: [phone]
JoshAFairhead.com http://www.JoshAFairhead.com
Ask the Loomio!?
https://www.loomio.org/join/group/2dzzxELw5H6STeR55EMp2F79/

ᐧ

On Sat, 15 Jun 2019 at 19:48, Andre Breton [e-mail] wrote:

@Joshfairhead https://github.com/Joshfairhead you should be able to
collect now on your milestones tab, please confirm thank you! have a nice
weekend

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Giveth/giveth-dapp/issues/819?email_source=notifications&email_token=AIILIQZJUJBV5JQM7UDRTTDP2U2O7A5CNFSM4HWR3LTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXY556I#issuecomment-502390521,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIILIQ7GVMQGRJP77D4KJPLP2U2O7ANCNFSM4HWR3LTA
.

[Joshfairhead]

Nice,

So looking at https://bridge.beta.giveth.io/ it seems that we are golden.
Thanks Andre, you da man!
ᐧ

[GriffGreen]

Adding fix to make it so you can't mark it complete

[Joshfairhead]

You'll have to catch it at the bridge then mawhahaha :p

(But idiot proofing it makes sense for sure!)

On Mon, 17 Jun 2019, 18:06 Griff Green, [e-mail] wrote:

Adding fix to make it so you can't mark it complete

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Giveth/giveth-dapp/issues/819?email_source=notifications&email_token=AIILIQ425DLDDBTGHN7NTGTP27ADHA5CNFSM4HWR3LTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX32PUY#issuecomment-502769619,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIILIQYLLMPF7CBTZFJJN3TP27ADHANCNFSM4HWR3LTA
.