Giveth-dapp: Milestone and Campaign Reviewer management

[vojtechsimetka]

Description:
The smart contracts allow for the Milestone and Campaign reviewer to be changed. To change reviewer, one has to call tho action Change Reviewer (called by old reviewer) and Accept New Reviewer (called by new reviewer). These should be two buttons in the UI.

Task:

• [ ] Add Change Reviewer button for Campaigns https://github.com/Giveth/lpp-campaign/blob/master/contracts/LPPCampaign.sol#L103 . This button should be visible only for current Campaign reviewer and should open a popup in which the reviewer can select new one from the reviewer whitelist. Calling this action should dispatch email to the newly nominated reviewer.
• [ ] Add Accept Reviewer Role button for Campaigns https://github.com/Giveth/lpp-campaign/blob/master/contracts/LPPCampaign.sol#L108 .
• [ ] Add Change Reviewer button for Milestones https://github.com/Giveth/lpp-milestones/blob/lp-1.0.0/contracts/Milestone.sol#L130
  - [ ] Add Accept Reviewer Role button for Milestones https://github.com/Giveth/lpp-milestone/blob/master/contracts/LPPMilestone.sol#L95
• [ ] When Milestone reviewer is changed, it should be registered in the milestone status updates
  

Work time estimate:
5-10h

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 300.0 DAI (300.0 USD @ $1.0/DAI) attached to it__ as part of the Ethereum Community Fund via ECF Web 3.0 Infrastructure Fund fund__.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
  
  
  
  • Want to chip in? Add your own contribution here.
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $48,592.36 more funded OSS Work available on the Gitcoin Issue Explorer
  
  

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Workers have applied to start work__.

These users each claimed they can complete the work by 12 months from now.
Please review their action plans below:

1) cryptomental has applied to start work _(Funders only: approve worker | reject worker)_.

Hi. I would like to start working on this bounty after I finish with milestone donations. Estimated PR Wednesday EOD.

Learn more on the Gitcoin Issue Details page.

[gitcoinbot]

@cryptomental Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@cryptomental Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[cryptomental]

Hi! My giveth milestone donations bounty takes me more time than I had expected and I would like to be fair and not to block this bounty to others. I will therefore press 'stop' button on GitCoin to unblock it.

[iamonuwa]

@vojtechsimetka I would love to pick up this task. I've started work already on this.

[cryptomental]

Hi @iamonuwa it is great that you picked it up immediately. All the best with the bounty!

[vojtechsimetka]

@iamonuwa please feel free to work on this. This issue was funded by ECF so @mkosowsk needs to approve you. Thanks again for the funding!

[mkosowsk]

Hi @iamonuwa, you are now approved :)

[iamonuwa]

@cryptomental thank you

[iamonuwa]

@vojtechsimetka am getting
{ code: -32603, message: "gas required exceeds allowance or always failing transaction" } when am sending a request to changeReviewer() (https://github.com/Giveth/lpp-campaign/blob/master/contracts/LPPCampaign.sol#L103)

[iamonuwa]

@vojtechsimetka are you there?

[vojtechsimetka]

Hi, what are the params that you are passing to the contract? Also did you try to increase the gas limit for that tx?

[iamonuwa]

@vojtechsimetka am passing the newReviewer address as requested by the LPPCampaign. I did not increase the gas limit

[iamonuwa]

@vojtechsimetka are you there?

[vojtechsimetka]

@iamonuwa try adding extra gas like here. https://github.com/Giveth/giveth-dapp/blob/237a8d70c7d54e8f796a8972c189dd02c64a3a9a/src/services/DonationService.js#L129

[iamonuwa]

@iamonuwa try adding extra gas like here.

giveth-dapp/src/services/DonationService.js

Line 129 in 237a8d7

return contract.mTransfer(encodedPledges, receiverId, {

Cool. Will do that now.

[gitcoinbot]

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[iamonuwa]

@gitcoinbot work in progress

@vojtechsimetka how do I get the new reviewer's details. Am asking this because the second feature is for the new reviewer to accept the review request. Any field on the data that indicates you have a review request?

[ceresstation]

Hey @vojtechsimetka just wanted to check to see if you and @iamonuwa had a chance to sync on the above question :)

[vojtechsimetka]

Hey @ceresstation Thanks for checking :) . Rather confusingly the answer is in the PR itself but I believe it is clear https://github.com/Giveth/giveth-dapp/pull/508#issuecomment-433014496

[ceresstation]

Ah, yep I missed that, thanks for clarifying!

[ewingrj]

I just implemented milestone recipient changing. Probably would be useful to look at for this work.

https://github.com/Giveth/giveth-dapp/commit/6b2dce556dccd661bf2daa127bd74348a727c11e

Also, note that I would recommend implementing this on top of the feature/new-milestones branch. It removes the accept phase when changing the milestone reviewer.

[mroberts10]

@gitcoinbot open issue - can you help us find another person for this issue

[iamonuwa]

@mroberts10 I'll work on it and get it done now.

[GriffGreen]

@iamonuwa is there something we need to do? :-D?

[GriffGreen]

@iamonuwa just so you know, we made things easier... @ewingrj might have something to add

[ewingrj]

note, I edited the description a bit to reflect the current contracts

[GriffGreen]

@iamonuwa Are you still on this?

[GriffGreen]

@gitcoinbot I think we need a new person to tackle this

[GriffGreen]

Hey @iamonuwa if you have any issues or are stuck on something feel free to join the riot chat and ask there: https://riot.im/app/#/room/#giveth-product-development:matrix.org

And you are also invited to our DApp meetings which happen at 6 pm Barcelona time every Friday at https://meet.jit.si/giveth-dapp ;-D

[gitcoinbot]

@toya999 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[GriffGreen]

oooooo! https://gitcoin.co/issue/Giveth/giveth-dapp/489/1401

It looks like @toya999 is on the case! Message us if you have any issues Toya! Also we have dapp meetings every Monday at 7pm Barcelona time at https://meet.jit.si/giveth-dapp if you want to join ;-)

Much love!

[gitcoinbot]

@toya999 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@toya999 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@toya999 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@toya999 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@toya999 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@toya999 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@toya999 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@toya999 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@toya999 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@toya999 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@toya999 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@toya999 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days