Giveth-dapp: Milestones that have no funding get marked complete and then can't receive funding

[GriffGreen]

There are many solutions to this very common error.
Options:

1. Milestones cannot be marked complete unless they have some funding
2. If a Milestone has no funding an extra warning box comes up when marking it complete
3. Even if a milestone is marked complete, the UI allows for funds to be sent to it.

Each of these has its own pros and cons... My fave is 2 but any solution including one not listed here is fine :-D

[krrisis]

You should also delete Milestones that are now marked complete and have no funding as they now just appear double in the DApp which is quite confusing. Or.. create the option for us to delete these. thx!

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 75.0 DAI (75.0 USD @ $1.0/DAI) attached to it__ as part of the Ethereum Community Fund via ECF Web 3.0 Infrastructure Fund fund__.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
  
  
  
  • Want to chip in? Add your own contribution here.
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $40,367.41 more funded OSS Work available on the Gitcoin Issue Explorer
  
  

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work has been started__.

These users each claimed they can complete the work by 7 months from now.
Please review their action plans below:

1) mikaoelitiana has applied to start work _(Funders only: approve worker | reject worker)_.

I will study all possible solution and confirm final choice with you before implementing

Learn more on the Gitcoin Issue Details page.

2) richardzhu123 has been approved to start work.

Tackle second approach to solution, from the list of three:

Milestones cannot be marked complete unless they have some funding
If a Milestone has no funding an extra warning box comes up when marking it complete
Even if a milestone is marked complete, the UI allows for funds to be sent to it.

Learn more on the Gitcoin Issue Details page.

3) richardzhu123 has applied to start work _(Funders only: approve worker | reject worker)_.

Tackle second approach to solution, from the list of three:

Milestones cannot be marked complete unless they have some funding
If a Milestone has no funding an extra warning box comes up when marking it complete
Even if a milestone is marked complete, the UI allows for funds to be sent to it.

Learn more on the Gitcoin Issue Details page.

[vojtechsimetka]

To whoever starts working on this: please implement option 3. All the way until Paid it should be able to receive money. Unless the smart contract does not allow it @perissology ? I don't think there is such restriction. https://github.com/Giveth/lpp-milestone/blob/master/contracts/LPPMilestone.sol

[millnitzluan]

@vojtechsimetka The donate button will appear even if the milestone has been fully funded?

[vojtechsimetka]

@millnitzluan no, when the fullyFunded === true the button should not be displayed. Please use that flag on the milestone response. E.g. here https://github.com/Giveth/giveth-dapp/blob/ff091bf43c86630fa2e74cebe6ec04d8c7cfb9ba/src/components/views/ViewMilestone.jsx#L85

[millnitzluan]

Is what I'm thinking to do.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work for 75.0 DAI (75.0 USD @ $1.0/DAI) has been submitted by__:

1. @millnitzluan

@mkosowsk please take a look at the submitted work:

• PR by @millnitzluan

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $45,760.19 more funded OSS Work available on the Gitcoin Issue Explorer

[mkosowsk]

Hi @millnitzluan, is there an update on this PR? Thanks! 👍

[millnitzluan]

@mkosowsk, I'm working on that

[krrisis]

hey @millnitzluan finding a solution for this one? Or should we open this up again? Thanks!!

[millnitzluan]

@krrisis I've stopped the work on gitcoin and said it on the PR, I couldn't find the solution.

[frankchen07]

The issue on Gitcoin has been reopened!

[icole]

Is this still an issue that might be good for a first time contributor? Would be interested in taking a crack at it if so.

[GriffGreen]

Yeah @icole Would love to see some action on this issue... its been a thorn in my side for too long! We are all just getting out of some conferences.. @vojtechsimetka will probably be around to authorize work on this soon :-D if you need a more specific understanding of this... ping @griffgreen:matrix.org on https://riot.im/app/#/room/#giveth-product-development:matrix.org

[GriffGreen]

man... i swear this happens to me 3 times a month minimum... sooooo many people do this and it is sooooooo annoying :-( what do we gotta do to finish this

[vojtechsimetka]

This is fixed since #81 .

[gitcoinbot]

@richardzhu123 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[RichardZhu123]

Work in Progress - Didn't receive notification from GitCoin that the request had been approved and the my started bounties page is blank for me in GitCoin. Sorry about that!

[ewingrj]

there is nothing to work on. it's already fixed. not sure why gitcoinbot commented here. sorry about that

[gitcoinbot]

@richardzhu123 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@richardzhu123 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@richardzhu123 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@richardzhu123 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@richardzhu123 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@richardzhu123 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@richardzhu123 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@richardzhu123 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@richardzhu123 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@richardzhu123 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@richardzhu123 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@richardzhu123 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [ ] reminder (3 days)
• [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[krrisis]

@gitcoinbot could you plz close this? thank you!