Giveth-dapp: Do not allow negative donation values in donation modal

[anshumanv]

I think we should restrict the min amount to 0 rather than going in negatives.

[vojtechsimetka]

Please go ahead, I just did not find easy way of doing so.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to it__ as part of the Ethereum Community Fund via the ECF Web 3.0 Infrastructure Fund fund__.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
  
  
  
  • Want to chip in? Add your own contribution here.
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $21,307.16 more funded OSS Work available on the Gitcoin Issue Explorer
  
  

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work has been started__.

These users each claimed they can complete the work by 6 months, 2 weeks from now.
Please review their action plans below:

1) anshumanv has been approved to start work.

Will debug the issue locally and send a patch ASAP

Learn more on the Gitcoin Issue Details page.

2) mostafazke has applied to start work _(Funders only: approve worker | reject worker)_.

just add regex validation to donation input

Learn more on the Gitcoin Issue Details page.

[anshumanv]

Hey @mkosowsk can you approve my request on gitcoin? Already working on the fix. :)

[mkosowsk]

Hey all, approved @anshumanv for work on this bounty as they originally submitted the bug ticket. Thanks to all those that applied!

[mkosowsk]

If you're interested in doing work on the Giveth or other Web 3.0 repos for the ECF Web 3.0 Infrastructure fund, you can

1. Find existing issues and submit a bounty request via https://gitcoin.co/requests

2. Create new issues and also submit a bounty request via https://gitcoin.co/requests

Happy hunting!

[mkosowsk]

@GriffGreen do you have a moment to review @anshumanv's code? If this passes spec, @anshumanv please submit at your earliest convenience :)

As Griff says, this is probably a bit rich for funding but we are happy to get the ball rolling with starting funding issues on Giveth 👍

[vojtechsimetka]

Thank you @mkosowsk ! I just did the review and requested few changes.

Also thank you very much for the funding opportunities, we really appreciate it. We are going to submit a bunch of issues very soon.

[mkosowsk]

Thanks! But don't thank me, thank the Ethereum Community Fund! It's their money, I'm just happy to spend it 😂

[mkosowsk]

@vojtechsimetka please let me know if there's any help you need in filling out the Gitcoin Requests. Very happy to fund an excellent project :)

[gitcoinbot]

@anshumanv Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[mkosowsk]

Hi @anshumanv have you had a chance to review requests from @vojtechsimetka? Thanks! 👍

[anshumanv]

Hey @mkosowsk, yes received the review and I know my next steps, will make the requested changes :+1:

Thanks for your patience. :smile:

[gitcoinbot]

@anshumanv Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[anshumanv]

Waiting for view. :+1:

[mkosowsk]

Hi @vojtechsimetka have you had a chance to review @anshumanv's latest work? Thanks!

[vojtechsimetka]

Hi @mkosowsk yes I did give him a feedback earlier. Thank you!

[vojtechsimetka]

@mkosowsk this bounty can now be paid out. Thank you @mkosowsk and ECF!

Thanks @anshumanv !

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work for 100.0 DAI (100.0 USD @ $1.0/DAI) has been submitted by__:

1. @anshumanv

@mkosowsk please take a look at the submitted work:

• PR by @anshumanv

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $49,982.28 more funded OSS Work available on the Gitcoin Issue Explorer

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__The funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @anshumanv.__

• Learn more on the Gitcoin Issue Details page
  
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $50,456.08 more funded OSS Work available on the Gitcoin Issue Explorer