Giveth-dapp: Getting refund/canceling is too easy

[vojtechsimetka]

Several non-recoverable actions are too easy to perform in the DApp. These are:

• Cancel Milestone
• Delete Milestone
• Cancel Campaign
• Refund donation

The buttons for these actions should be visible, but the confirmation should be more difficult like deleting a Github Repository.

Task:

• [ ] Create popup component for non-trivial actions that will ask to copy the title of the Milestone/Campaign or the amount of donation (first 5 digits)
• [ ] Replace the confirmation flow for these actions with the newly created component

Example how it looks on Github

[vojtechsimetka]

@anshumanv @vs77bb How do you like this one? More are coming :).

[anshumanv]

This is super interesting! :open_mouth:

I'll surely love working on this. :tada:
cc @vs77bb :sparkles:

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 300.0 DAI (300.0 USD @ $1.0/DAI) attached to it.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $30,142.51 more funded OSS Work available on the Gitcoin Issue Explorer

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work has been started__.

These users each claimed they can complete the work by 6 months, 3 weeks ago.
Please review their action plans below:

1) anshumanv has started work.

Nothing so far, I'll follow up if I'm stuck somewhere, excited!

Learn more on the Gitcoin Issue Details page.

[anshumanv]

Hey @vojtechsimetka :wave: Super excited to work with you again! :smile:

I tried reproducing the issue and wanted to clarify about 2 parts,

• I'm no longer to make the donations since I think some changes are done recently and wallet doesn't have anymore ETH to test maybe? It ways insufficient balance when I try to make donations.
• I see the options to cancel milestone/campaign, where's the option to delete milestone? :sweat_smile:

[vojtechsimetka]

Hey @anshumanv sorry for late response:

I'm no longer to make the donations since I think some changes are done recently and wallet doesn't have anymore ETH to test maybe? It ways insufficient balance when I try to make donations.

Yes we have change the DApp so that you have to use external web3 provider to donate. All you need to do is import one of the keystores to metamask.

I see the options to cancel milestone/campaign, where's the option to delete milestone?

Milestones can be deleted only when they are proposed (meaning you "create" a milestone in campaign that is not made by you) and they can be deleted only until they are accepted by the Campaign lead.

[anshumanv]

Yes we have change the DApp so that you have to use external web3 provider to donate. All you need to do is import one of the keystores to metamask.

Okay, lost track of the recent changes, will try this.

Milestones can be deleted only when they are proposed (meaning you "create" a milestone in campaign that is not made by you) and they can be deleted only until they are accepted by the Campaign lead.

Makes sense, I'll try playing around with it. :+1:

Thanks for the help again @vojtechsimetka :smile:

[anshumanv]

Hey @vojtechsimetka how about adding a text field to the sweetalert popup as we're using right now?

[vojtechsimetka]

Yeah that works :). Can you also highlight (just like this) the par that needs to be copied?

[gitcoinbot]

@anshumanv Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[anshumanv]

I'll complete this today.

[vs77bb]

How's this going @anshumanv? Hope you're doing well 🙂

[anshumanv]

Hey @vs77bb I'm at my best and hoping for you the same. This is almost done and a WIP PR is at https://github.com/Giveth/giveth-dapp/pull/443 the task is completed, just need some refactoring, will be doing this tomorrow. :+1: :sparkle: Thanks for checking it up!

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work for 300.0 DAI (300.0 USD @ $1.0/DAI) has been submitted by__:

1. @anshumanv

@vs77bb please take a look at the submitted work:

• PR by @anshumanv

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $28,962.82 more funded OSS Work available on the Gitcoin Issue Explorer

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__The funding of 300.0 DAI (300.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @anshumanv.__

• Learn more on the Gitcoin Issue Details page
  
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $28,715.15 more funded OSS Work available on the Gitcoin Issue Explorer