Gitup: Typing to select a popup menu item triggers key commands in map view.
When you right click on a revision, typing to select a menu item instead triggers quick keys. Menus opened from the menubar don't have the same issue.
fjolnir
All 4 comments
I'm not really sure this is something we'd want to "fix". The intent is to show you the key to hit in order to trigger the action so we kind of still want the quick keys to be active.
lucasderraugh
on 27 Feb 2020
Matter of taste I guess. Surprised me.
fjolnir
on 27 Feb 2020
Definitely understand what you're getting at here. I'm just not sure it's a change we'd want to make. Feel free to leave it open though and see if anyone else chimes into agree/disagree.
lucasderraugh
on 27 Feb 2020
One way I often encounter this is when I right click on a branch tip and then go into the "Merge Into..." menu, which in my case is a list of a dozen branches. Then I'll tyope the first few letters of the branch I want and it will trigger all sorts of GitUp shortcuts instead of selecting the right branch. I think the normal macOS behaviour would be to not respond to single key presses if a contextual menu is shown.
lapfelix
on 27 Feb 2020
Related issues
gotjoshua
路
4Comments
brandedoutcast
路
3Comments
swisspol
路
7Comments
FadeFei
路
5Comments
sindresorhus
路
6Comments
Most helpful comment
One way I often encounter this is when I right click on a branch tip and then go into the "Merge Into..." menu, which in my case is a list of a dozen branches. Then I'll tyope the first few letters of the branch I want and it will trigger all sorts of GitUp shortcuts instead of selecting the right branch. I think the normal macOS behaviour would be to not respond to single key presses if a contextual menu is shown.