Github: branch name showed twice on bottom bar

[ungb]

I believe that one is from the git package and the other is from the github package.

See image below:

[simurai]

Yeah, I think the first branch comes from the status-bar package. And the 2nd branch from the GitHub package.

I only can reproduce this if I have a dev version of status-bar linked (apm link -d).

[BinaryMuse]

@kuychaco I think I'm going to change the code that removes the old branch name to use feature detection instead of version checking.

[BinaryMuse]

So we're gonna handle this by ensuring that this package can't be installed on versions of Atom that are old enough to cause this issue (the current beta should be fine, so by the time we staff ship the issue should go away). Leaving this open until that change gets made.

[ungb]

Do you know if this will impact staff ship?

[iolsen]

If we hold the next release until January, I think we can go ahead with staff-ship. Because this is cosmetic and the staff ship audience is friendly, I'd prefer we just mention it in the team post (use the current beta or you'll see this oddity) and not worry about holding staff ship or hotfixing stable.

[ungb]

This also impacts pull, push, fetching and the ability to change/create branch features that don't work on 1.12.x, but works on 1.13-beta. @iolsen

[iolsen]

OK. But if the github package prevents itself from installing < 1.13, and we tell people they need the current beta, we're OK right?

[ungb]

yup! that should be fine 👍

[iolsen]

We've also discussed holding staff ship until after the holidays in hopes of getting more/better feedback, so it's possible this is all moot. I think @BinaryMuse's workaround has us covered if we decide to staff ship this first.

[BinaryMuse]

Discussed this with @kuychaco and we agreed that our personal preference would be to not staff ship the package until we roll the railcars. I can't help but wonder if requiring beta would raise the activation energy of testing it high enough that people won't do it. It also means that people would be using and testing the package as they're gearing up on work after the holidays as opposed to doing so while winding down.

[iolsen]

I've been leaning that way, too. Let's call that the plan of record then.