Github-readme-stats: What is S rank?

[hugovk]

Describe the bug

When I add include_all_commits=true my badge goes from A++ to S+

Expected behavior

I don't know what I expected, but I've no idea what S+ means. S is way down the alphabet, is it much worse than A-F?

Screenshots / Live demo link (paste the github-readme-stats link as markdown image)

[![hugovk's GitHub stats](https://github-readme-stats.vercel.app/api?username=hugovk&count_private=true&show_icons=true&hide_title=true)](https://github.com/anuraghazra/github-readme-stats)

Add include_all_commits=true:

[![hugovk's GitHub stats](https://github-readme-stats.vercel.app/api?username=hugovk&count_private=true&show_icons=true&hide_title=true&include_all_commits=true)](https://github.com/anuraghazra/github-readme-stats)

Screenshot

[jopemachine]

I don't know what I expected, but I've no idea what S+ means. S is way down the alphabet, is it much worse than A-F?

I think S means much better than A or A++. (not much worse than A-F).

That means the rating has gone up because the total number of commit is much higher when you include all your commit (private commits).

[Metalhearf]

This maybe could interest you, about the _S to F_ grading.
https://en.wikipedia.org/wiki/Academic_grading_in_Japan

[hugovk]

OK, thanks, good to know!

I wonder how widely know Japanese grading is. Perhaps it'd be better to shift the grades to begin with A and end with, say, C.

Or add some extra pluse to the existing to A, rather than S.

Thanks!

[anuraghazra]

Yeah I guess I'll change this. A lot of people recommend me not to use S because it's confusing.

I intentionally did this to curve the rankings toward A and A++ even for low active users.

[avelino]

This maybe could interest you, about the _S to F_ grading.
https://en.wikipedia.org/wiki/Academic_grading_in_Japan

Could you put in the documentation README

[HelloRusk]

To be honest, rank S is not so popular even in Japan.
I've lived in Japan for 20 years and never had such grading systems.

[anuraghazra]

I've lived in Japan for 20 years and never had such grading systems.

It's mostly used in fictional grading. highly used in modern PC games.

[landonepps]

I intentionally did this to curve the rankings toward A and A++ even for low active users.

Is it even possible to get a B+?
https://github-readme-stats.vercel.app/api?username=tranminhson100
Here's a user with nearly as little activity as possible, and they have an A+.

[AryanBeezadhur]

I'm disappointed to know that I have the same ranking as this user when I am much more active :(

[AryanBeezadhur]

I think rank is largely biased towards issues, not commits or PRs or forks, because look at this user with a top rank and no commits:

(https://github-readme-stats.vercel.app/api?username=vscode-triage-bot&show_icons=true&count_private=true)

[HelloRusk]

https://github.com/anuraghazra/github-readme-stats/blob/master/src/calculateRank.js#L28-L34

The number of commits or contributions is weighted only 1.65 times as the number of issues you've opened. This evaluation is somewhat mismatched.
Maybe we should open another issue to discuss better way of ranking.

[HelloRusk]

related to #455

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[hugovk]

Stale bot, please keep open, awaiting changes: https://github.com/anuraghazra/github-readme-stats/issues/330#issuecomment-671012692