Githawk: Mute and more buttons don't work when a thread is read

Created on 28 Feb 2019  ·  9Comments  ·  Source: GitHawkApp/GitHawk

GitHawk Upload by mesqueeb

🐛 bug ✨ good first issue

Most helpful comment

I'll take a look at this if no one has started on it yet

All 9 comments

I'll take a look at this if no one has started on it yet

@RJ-Clegg How it going?

  • It's often I mark a thread as "read" by mistake, try to mark it "unread" again, but can't because of this bug.
  • Another case I often have is I mark a thread "read", then try to turn off notifications, but cannot do that because of this bug.

I feel a looooot of people would be really excited for your fix! 💘🎉

Hi, is there an update on this?

Sent with GitHawk

I think not yet, it's still bugged in my version 😔very annoying but it's a free app so I won't complain? 😁

Sent with GitHawk

Well I ask because I would like to contribute to the project and seemed like this would be a good issue to work on. However it looks like @RJ-Clegg was working on it?

I don’t understand how issue assignment works here.

It’s a bit tricky as you can’t assign tickets to outside contributors. Feel free to pick it up, @albertbass86, and let us know if we can help!

Sent with GitHawk

Cool! I was wondering if it was fine for me to just pick it. Will give it a try. Thank you 👌

Sent with GitHawk

Hi again, I have a simple solution but it feels a bit like a workaround.

It involves just adding a hitTest to the notification cell so touches are captured by the buttons instead of the cell. I feel like there is a different solution but I do not have enough context of the app to be sure.

Do you want me to create a PR and see @BasThomas or do you have pointers towards a different approach?

Feel free to open a pull request, and we can continue from there.

I think it already uses a hit test rather than being able to tap the buttons in the cell?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

BasThomas picture BasThomas  ·  3Comments

BasThomas picture BasThomas  ·  3Comments

BasThomas picture BasThomas  ·  3Comments

viktorgardart picture viktorgardart  ·  3Comments

jessesquires picture jessesquires  ·  3Comments