Githawk: Use GithubURL methods for github url construction

Created on 20 Feb 2019  Â·  3Comments  Â·  Source: GitHawkApp/GitHawk

In #2622 GithubURL was introduced which should be used for all Github URL building across the app.

  1. use concrete methods (i.e GithubURL.codeBlob) for all URL buildings
  2. cover w/ unit tests
🎯 project management ✨ good first issue

Most helpful comment

This seems like an interesting issue. Is anyone working on it? If not I could give it a spin. 😅

All 3 comments

1121 is a bit related I think because having a nested struct for each Repo node like Issue, PR, ... would make Github URL construction easier

struct RepoPath {
  let owner: String
  let repo: String
}

This seems like an interesting issue. Is anyone working on it? If not I could give it a spin. 😅

@RuiAAPeres it's all yours

Was this page helpful?
0 / 5 - 0 ratings

Related issues

BasThomas picture BasThomas  Â·  3Comments

rnystrom picture rnystrom  Â·  3Comments

rnystrom picture rnystrom  Â·  3Comments

BasThomas picture BasThomas  Â·  3Comments

rizwankce picture rizwankce  Â·  3Comments