Githawk: Press and hold for tag title

Created on 9 Dec 2018  Â·  13Comments  Â·  Source: GitHawkApp/GitHawk

If you see a tag in a comment like #000, you should be able to press and hold on it (kinda like press on GitHawk badge) to get a menu controller pop up with the tags title.

Sent with GitHawk

🆕 feature request ✨ good first issue

All 13 comments

Should there also be 3D Touch support?

That’s cool where else do we have that? I have XR so no 3D Touch :(

Sent with GitHawk

I don’t think there’s any other 3D Touch capabilities in-app at this point unfortunately.

@j-f1 #377 is opened for 3D Touch. Unsure what it’s status is. Looks untouched atm so feel free to pick it up.

Sent with GitHawk

Ah it took a minute for me to understand this... this would be similar to how GitHub has the hover on web, right?

Would indeed be nice to peek/pop as well!

@BasThomas Yes correct, similar to hover

Is this issue still not fixed? if so I can do it.
I have some questions:

  1. Is it just the title that you want to show up when it is pressed and held?
  2. Is it just in the issues view where this feature should be?
  3. ForFeed.swift I can't seem to find the UITextViews in it, can you tell me in which variable they are located in? I'm very new to the CodeBase.

@Abemarkar23 ya pretty sure it’s still open! Go for it!

  1. I think that’s a good way to start!
  2. Should happen for all tags #2539 wherever they are.
  3. Not by my computer maybe @BasThomas knows !

Looking forward!

Sent with GitHawk

@Huddie How do i communicate with @BasThomas?

👋 Not sure where, will take a look!

Sent with GitHawk

3. ForFeed.swift I can't seem to find the UITextViews in it, can you tell me in which variable they are located in? I'm very new to the CodeBase.

So, looking at this now, I'm not entirely sure what it is you're looking for. Are you looking for the MarkdownStyledTextView that is used within the IssueCommentTextCell, perhaps?
Let me know if that helps!

@Abemarkar23 if you say his name 3 times he appears :). Just kidding. He’s around just tag him if you need

Sent with GitHawk

@Abemarkar23 still on it?

Sent with GitHawk

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rnystrom picture rnystrom  Â·  3Comments

rizwankce picture rizwankce  Â·  3Comments

jessesquires picture jessesquires  Â·  3Comments

viktorgardart picture viktorgardart  Â·  3Comments

rnystrom picture rnystrom  Â·  3Comments