Githawk: Add Danger or equivalent

Created on 2 Dec 2018  路  5Comments  路  Source: GitHawkApp/GitHawk

As mentioned in #2514 the project is getting bigger and a bot would help @rnystrom with PR + other automation (like: #2405).

We discussed adding Danger to the project, I think @BasThomas suggested some derivative of Danger (Peril?). I guess this issue is to spark conversation on exactly which bot, what it can do for the project and get this thing moving a bit.

馃啎 feature request

All 5 comments

Open to suggestions!

Here are a few:

  • Xcode Summary: Displays warnings/failed tests/errors in PRs
  • Changelog: With the new feature banner coming to GitHawk we have to update the Release-Notes repo. To make life easier, all new feature PRs should be required to enter a short blurb in the changelog so that we can easily create release notes. Changelog would be housed in the GitHawk repo. Danger will check for a change in the CHANGELOG.md and if none are found, comment on the PR.
  • Auto Label: Labeling PRs will make tracking them easier. If the title of a PR contains [WIP] it will be assigned a WIP label, this can be expanded to add "waiting-on-review" or "ready-to-pull". Not all contributors have access to adding labels so this is a good way to keep PRs tracked.
  • SwiftFormat/ SwiftLint: We currently use swiftlint, I think SwiftFormat can make PR review a bit simpler since SwiftFormat + Danger will auto-format the project when PRs get merged. If we use SwiftLint, we should also add it to Danger so that Danger can comment a SwiftLint report. We may be able to use this + auto label to make it so that only once no lint issues appear can you request a review/ get an "waiting-for-review" label added by Danger

Regarding Danger / Peril: I feel like Danger does enough for us at this point, and would be easier to setup (no server needed).

964 just to tag it since this could close that issue

Sent with GitHawk

If we could also make it that danger reports why builds are failing that could be helpful. Either spit back exactly what Bitrise error is or for example
If a new file was added but .pbxproj wasn鈥檛 updated, inform user of the issue

Sent with GitHawk

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rizwankce picture rizwankce  路  3Comments

jessesquires picture jessesquires  路  3Comments

BasThomas picture BasThomas  路  3Comments

BasThomas picture BasThomas  路  3Comments

rnystrom picture rnystrom  路  3Comments