Githawk: Cancel network request if user backs out of view

[Huddie]

If you enter an issue and swipe back while it’s loading you may receive a squawk alert a few seconds later telling you network request failed. I think this happens because when you dismiss a view that’s currently in the middle of a network request we leave the request going.

To reproduce:

• Open an issue with bad network connection
• Dismiss before request returns (before view loads)
• Wait

You should see the alert.

I think we should maybe cancel all network requests when you dismiss a view

Edit: It doesn’t seem to always show an alert. My guess is that sometimes these request don’t time out and actually return? I’m not quite sure but I’m pretty sure that the request live on past the life of the vc

Bug Report Dump (Auto-generated)

Version 1.25.0 (1542806489)
Device: iPhone XR (iOS 12.1)
TestFlight: false

[rnystrom]

Yesssss. This is pretty wasteful atm. We don’t store a token or anything for in flight requests, which is prob step one. Then on VC deinit we cancel requests for all tokens?

Also should prob be selective. For instance we don’t want to cancel mutations (eg add comment)

_{Sent with GitHawk}

[Huddie]

There are so many fun issues to complete

_{Sent with GitHawk}