Githawk: Bug report incorrect in terms of whether user is on TestFlight

[Huddie]

This was created on the TestFlight build

See dump below says false

Bug Report Dump (Auto-generated)

Version 1.25.0 (1542806489)
Device: iPhone XR (iOS 12.1)
TestFlight: false

[rnystrom]

Hmph. @rizwankce ?

_{Sent with GitHawk}

[Sherlouk]

Was this a GM build @Huddie? The TestFlight flag only works if a specific TestFlight build is used. I know Ryan pushes a final build to TF usually before pushing to the App Store where this doesn't work

[Sherlouk]

Can confirm just checked, notes for that version 1542806489 are "1.25.0 GM 2"

[Huddie]

Oh so this is proper. Didn’t know that is how it worked. @Sherlouk what will happen if I tapped “try beta” in settings? Same thing? It will assume I’m not on beta?

_{Sent with GitHawk}

[Huddie]

Not really sure why I asked that and didn’t just check. So ya it assumes your not on beta.

_{Sent with GitHawk}

[Sherlouk]

Correct yea it uses the same system. It all works based on a compiled flag and was first added for FLEX debugging purposes - see this file:

https://github.com/GitHawkApp/GitHawk/blob/8452d73ab9aab9db3891dce102c4b1574acc95d0/Classes/Views/FlexController.m#L11-L13

https://github.com/GitHawkApp/GitHawk/blob/8452d73ab9aab9db3891dce102c4b1574acc95d0/fastlane/Fastfile#L18

Fastfile above shows how we can create a TF build vs just a normal App Store build later in the file 😄

Valid point to raise though! We could consider using runtime checks for TF for things like bug reports and beta - though we must continue to use the compiler flag method for FLEX as we don't want that code making it's way into release builds

[Huddie]

@Sherlouk this probably explains why three finger tapping on this version does nothing lol. I spent a whole minute or 2 three fingering tapping on my screen this morning 🤦‍♂️. 😂

_{Sent with GitHawk}

[Sherlouk]

I've been right there with you and I added it in the first place 😂