Githawk: Try again for “Cannot load file type” does not work

Created on 27 Nov 2018  ·  6Comments  ·  Source: GitHawkApp/GitHawk

Thoughts:
1) Hook up try again to make it work
2) Remove try again (if we cannot load it the first time, we cannot load it the second time).


Bug Report Dump (Auto-generated)

Version 1.25.0 (1542806489)
Device: iPhone XR (iOS 12.1)
TestFlight: false

🐛 bug ✨ good first issue

All 6 comments

Does it actually not do anything, or does it just fail to load again? Does FLEX show new network requests?

Sent with GitHawk

@rnystrom I’ll check. It didn’t show the spinner which is usually the first thing that happens when the try again is pushed

Sent with GitHawk

It may just load too fast, but also may not be wired up 🤷‍♀️

Either way retrying will just error and show the same screen again. More important for situations where the screen actually fails to load

Sent with GitHawk

@rnystrom I tried with FLEX. No network requests expect the initial attempt.
This isn’t a big deal but I feel like if we have a button it should do something. Even though i suspect it will produce the same result

Sent with GitHawk

Ya this is def a bug then. Would stink to actually fail a network request then be stuck.

@Huddie feel free to nab

Sent with GitHawk

@rnystrom I'll take this after finishing the Github V4 mutation stuff for #2482. Just in case someone wants to pick this up in the meantime.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

BasThomas picture BasThomas  ·  3Comments

rnystrom picture rnystrom  ·  3Comments

jessesquires picture jessesquires  ·  3Comments

rnystrom picture rnystrom  ·  3Comments

rizwankce picture rizwankce  ·  3Comments