Githawk: Spinner finishes before code file loads

Created on 27 Nov 2018  ·  9Comments  ·  Source: GitHawkApp/GitHawk

  • If you go to this file: Freetime.xcodeproj/project.pbxproj

  • The spinner should end pretty quickly but the page will remain blank.

  • Wait

  • Document appears

I think the spinner should continue until the document is ready to show, I thought it was either blank or there was an error loading it

Sent with GitHawk

🐛 bug ✨ good first issue ❓ help wanted

All 9 comments

It’s from rendering the code in the background. Could be interesting to keep the spinner til rendering finishes. Requires a little refactoring on the CodeView I think. Great task for someone.

Sent with GitHawk

Could the unhighlighted code be displayed first, then replaced with the highlighted version?

Don’t see why not. Just kind of a weird UX

Sent with GitHawk

I’d rather show it styled instead of flashing with changes

Sent with GitHawk

Is this rendered in a uitextview or tableview? Maybe find ways to reduce the amount needing highlighting at a time

Sent with GitHawk

Text view

Sent with GitHawk

I know styledTextKit has a UITableView example. Would this help loading times?

Sent with GitHawk

It would if we split big chunks of text into smaller pieces (maybe by line count?) and then calculated code style in order.

Pretty complex tho.

Sent with GitHawk

Ya sounds complex. Just throwing things out there 🤷‍♂️

Sent with GitHawk

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rnystrom picture rnystrom  ·  3Comments

BasThomas picture BasThomas  ·  3Comments

rnystrom picture rnystrom  ·  3Comments

BasThomas picture BasThomas  ·  3Comments

rnystrom picture rnystrom  ·  3Comments