Githawk: Merge status pending

Created on 18 Nov 2018  Â·  10Comments  Â·  Source: GitHawkApp/GitHawk

Pretty sure when tests are pending on a PR it reads “merge status pending” rather than “tests pending”. Anyone able to confirm?

I forgot to take a screenshot sorry :/


Bug Report Dump (Auto-generated)

Version 1.24.0 (1542135906)
Device: iPhone XR (iOS 12.0.1)
TestFlight: false

🎨 design

Most helpful comment

Or keep it really simple with “Checks haven’t completed”, similar to GitHub’s message

Sent with GitHawk

All 10 comments

Would love to see an example to repro. Does GitHub have different statuses for CI running?

Sent with GitHawk

GitHawk Upload by Huddie

@rnystrom
Thanks! See the merge status pending. But it’s meant to say Test pending I believe

Sent with GitHawk

Is that what GitHub says for the same UI?

Sent with GitHawk

Looks like we could just update the language

GitHawk Upload by rnystrom

Sent with GitHawk

Sorry ya github has different language.
One seems like you can’t merge yet, one is just test.
Simple language update should be perfect 👌.
I should be able to do this unless someone is already on it

Sent with GitHawk

@Huddie go for it!

Sent with GitHawk

How about “X Check(s) pending?“

Or keep it really simple with “Checks haven’t completed”, similar to GitHub’s message

Sent with GitHawk

I should have this by end of day. Gonna go with the github styled one for now

Sent with GitHawk

Merged as is. Might wanna check iPhone 5 width to make sure it’s not too long. But probably fine.

Sent with GitHawk

Was this page helpful?
0 / 5 - 0 ratings

Related issues

weyert picture weyert  Â·  3Comments

BasThomas picture BasThomas  Â·  3Comments

BasThomas picture BasThomas  Â·  3Comments

Iron-Ham picture Iron-Ham  Â·  3Comments

weyert picture weyert  Â·  3Comments