Githawk: Bookmarks show all issues in blue regardless of if issue was open or closed

Created on 1 Nov 2018  ·  5Comments  ·  Source: GitHawkApp/GitHawk

Is this intentional to not reflect from the list whether they are in an open or closed state?

🆕 feature request

Most helpful comment

I was looking into this recently because of #2261. The bookmark model does not contain state so it just knows the notificationType.

I think changing this to match with notificationModel is a good idea.

Sent with GitHawk

All 5 comments

I was looking into this recently because of #2261. The bookmark model does not contain state so it just knows the notificationType.

I think changing this to match with notificationModel is a good idea.

Sent with GitHawk

The complication here is that you will have to fetch data to get the latest status. Pretty big change. Might want to do this alongside a larger bookmarks refactor.

Sent with GitHawk

Just making a note that this also results in edited titles not dynamically reflecting

Good point. I want tot totally refactor how we do bookmarks...

Sent with GitHawk

I’m sure I’m missing a few but at least bookmark items I’ve, for lack of a better word, bookmarked 🤷‍♂️

Just aggregating everything for ease when project plan is laid out-

In addition to those from this post :

  • icon reflect if item is open closed
  • dynamically reflect edited titles

2377

  • linked to iCloud for backup
  • integrate with github natively once api is released

1886

  • sort/reordering

2441

  • personal request to reflect total count
Was this page helpful?
0 / 5 - 0 ratings

Related issues

viktorgardart picture viktorgardart  ·  3Comments

rizwankce picture rizwankce  ·  3Comments

jessesquires picture jessesquires  ·  3Comments

BasThomas picture BasThomas  ·  3Comments

Iron-Ham picture Iron-Ham  ·  3Comments