Githawk: Discussion: Remove "Review GitHub Access" button on inbox

[drewvolz]

Is your feature request related to a problem? Please describe.

I am puzzled that there are two locations to review GitHub access within GitHawk. The first location is within the Settings tab within the app, and the second is on the empty inbox view. My issue is in thinking that it does not belong on the inbox view.

Describe the solution you'd like

What I would like to see is for https://github.com/GitHawkApp/GitHawk/pull/2176 to be reverted.

Describe alternatives you've considered

It could remain. It's not harming anyone. The alternative is to not remove it... but it currently exists at the top of GitHawk's Settings. I've found that it's currently buggy as-is (constraint might be setup incorrectly)

📸 Screenshot

Additional context

This is meant to be a discussion. I agree that @BrianLitwin did a fine job to get these changes in. I feel that those changes are out of scope for that view and duplicate functionality that exists within Settings.

[ijm8710]

Stating opinion that I would disagree. I feel
the one in settings is there in general, the one in inbox only appears with no notifications and serves as a double check on why you may not be getting them.

[BrianLitwin]

@drewvolz Good points! I'm going to try to fix those constraints really quick either way, but this is a good discussion to have. Thanks for posting the screenshot!

I agree that there probably is a better solution for user-initiated self-help, def worth exploring. I like the workflow in SettingsViewController with the Push Notifications "Info" button - an icon that opens a ContextMenu.

The original issue was #2067

[drewvolz]

Thanks for the feedback and context, @BrianLitwin, and for taking on tweaking the constraints. A self-help feature for this sounds very much worth exploring — I also like that workflow you mentioned for the Push Notifications context menu.

[rnystrom]

Had an idea over the weekend to replace the text with a “Missing notifications?” button. Tapping it brings up a menu with debug options like reviewing access, checking .com notifications, and finally filing an issue.

I agree that the current prompt is a little confusing.

_{Sent with GitHawk}

[tooomm]

I didn't realize that it is a clickable button until reading it here...

I came here today to open a ticket to get help about why it shows up and to troubleshoot that "Error" since I got no help in client what's up...
Because I only realized it since yesterday? and thought something broke with my GitHub access.

If it really is only a helpful reminder to double check why there might be no notifications for newer users... then it should be labeled differently!
The idea to have something like that is not bad in general, even though it is very prominent and repetitive because it doesn't matter in most cases and for most users.
Maybe it can be rethinked to provide help for the users that need it because there is a problem without constantly distributing fallacious concerns.

[gingerbeardman]

I came here after seeing "Missing notifications? " in an empty inbox (which should be empty, I've read all my current notifications)

Anyway I tap the text (I agree it doesn't look tappable like a button would) and end up on this page and I have zero idea why I've been sent there or what to do as there are no GitHawk mentions on the page? Plus I'm now in Safari not GitHawk. Help.

[rnystrom]

It’s just to review your access settings. Majority of the time folks expect notifications for an org or something that hasn’t granted permissions.

Good opportunity for someone to contribute a change.

_{Sent with GitHawk}

[Huddie]

Is there a way to check what access level the app has?

We redirect to github so that users can make sure they have the right permissions set, anyway to query for the permissions level? I’ll check when I get a chance unless someone knows.

_{Sent with GitHawk}

[rnystrom]

Not sure there may be

_{Sent with GitHawk}

[Huddie]

I’ll check!

_{Sent with GitHawk}

[gingerbeardman]

So should I be seeing GitHawk on the OAuth access page? It's not there for me.

I'm receiving notifications OK.