Githawk: Should reaction user popup direct to user profile

Created on 20 Oct 2018  ·  6Comments  ·  Source: GitHawkApp/GitHawk

Also, based off #2270, should determining who left the reaction stay as long press, or can it be tap (would need slight adjust not to conflict)

❔ question

Most helpful comment

We’d have to refactor the menu control to use something else (maybe context menu).

I think this feature would have lower value-add vs other things folks are working on.

Sent with GitHawk

All 6 comments

Tapping the reaction already adds or removes that reaction, similar to GitHub.com

Sent with GitHawk

Cool was just making sure bc of how you made obtaining those info graphics a tap in the app but yeah makes sense

What are your thoughts on the identifier pop ups linking to profiles

That would have to wait until we support profiles.

That would have to wait until we support profiles.

@BasThomas true I mean moreso mobile redirect-for now-similar to what happens if I click your username at top left of comment

We’d have to refactor the menu control to use something else (maybe context menu).

I think this feature would have lower value-add vs other things folks are working on.

Sent with GitHawk

What about putting each username in its own cell in the existing popup view and redirecting when the user taps on the username?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rnystrom picture rnystrom  ·  3Comments

BasThomas picture BasThomas  ·  3Comments

Iron-Ham picture Iron-Ham  ·  3Comments

viktorgardart picture viktorgardart  ·  3Comments

BasThomas picture BasThomas  ·  3Comments