Githawk: Push notification doesn’t mark as read

[Huddie]

Anyone else?

_{Sent with GitHawk}

[j-f1]

I can repro this too.

[rnystrom]

Can you explain the issue a little more? What is supposed to be read?

_{Sent with GitHawk}

[j-f1]

When you tap a push notification, the issue/PR isn’t marked as read in GitHawk’s inbox view.

[Huddie]

Ya what @j-f1 said. Push notifications open you to an issue but even though that means you’ve read the issue, the issue still shows in the inbox

_{Sent with GitHawk}

[BasThomas]

Yeah it seems to perform the route but the reading logic is here which is probably not being hit via the route.

[rnystrom]

Oh now I understand. If you have this enabled in settings, it'll work. But otherwise, it doesn't mark read unless you do it from the inbox.

Would you expect this to work as if you marked it read from inbox?

[Huddie]

I believe even with read on in settings it doesn’t read when opening via push. Anyone else able to confirm?

_{Sent with GitHawk}

[Huddie]

I just confirmed that opening from push does not mark the notification as read.

@rnystrom ya I feel like it should mark it as if read from inbox. Any reason why reading it via push is different from reading via inbox?

_{Sent with GitHawk}

[rnystrom]

Oh snap now I get it. The read logic is all in the notification SC.

_{Sent with GitHawk}

[ghost]

Other question, you only get notifications when the app runs in the background, right? Otherwise I‘m having a bug.

_{Sent with GitHawk}

[Huddie]

Yes thats correct

_{Sent with GitHawk}